Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Issue 2374853002: remove DownloadController::SetDefaultDownloadFileName() (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove DownloadController::SetDefaultDownloadFileName() All download now goes through Chrome's network stack. Default file name will be determined in download_target_determiner.cc. As a result, this function is no longer being called. BUG=647755 Committed: https://crrev.com/2ef8d9323057b8858ce2a17423c393663a803ef1 Cr-Commit-Position: refs/heads/master@{#421586}

Patch Set 1 #

Patch Set 2 : rebase to fix merge errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/browser/android/download/download_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/download/download_controller.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/download/download_controller_base.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/download/download_manager_service.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
qinmin
PTAL
4 years, 2 months ago (2016-09-27 23:01:42 UTC) #2
gone
lgtm
4 years, 2 months ago (2016-09-28 16:46:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374853002/1
4 years, 2 months ago (2016-09-28 16:50:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/38270)
4 years, 2 months ago (2016-09-28 17:09:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374853002/20001
4 years, 2 months ago (2016-09-28 17:58:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 18:34:52 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 18:36:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ef8d9323057b8858ce2a17423c393663a803ef1
Cr-Commit-Position: refs/heads/master@{#421586}

Powered by Google App Engine
This is Rietveld 408576698