Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 23745007: Fix browser.memory_stats has no GPU and Renderer info on CrOS (Closed)

Created:
7 years, 3 months ago by Owen Lin
Modified:
7 years, 3 months ago
Reviewers:
yuli, tonyg, Pawel Osciak
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, James Simonsen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix browser.memory_stats has no GPU and Renderer info on CrOS BUG=284219 TEST=run related code on daisy NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221637

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 1 chunk +4 lines, -5 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
Owen Lin
PTAL. So many thanks. https://codereview.chromium.org/23745007/diff/1/tools/telemetry/telemetry/core/platform/cros_platform_backend.py File tools/telemetry/telemetry/core/platform/cros_platform_backend.py (left): https://codereview.chromium.org/23745007/diff/1/tools/telemetry/telemetry/core/platform/cros_platform_backend.py#oldcode62 tools/telemetry/telemetry/core/platform/cros_platform_backend.py:62: return proc_util.GetChildPids(processes, pid) "pid" has ...
7 years, 3 months ago (2013-09-03 06:42:51 UTC) #1
yuli
lgtm
7 years, 3 months ago (2013-09-03 07:10:24 UTC) #2
Pawel Osciak
lgtm
7 years, 3 months ago (2013-09-03 07:19:51 UTC) #3
tonyg
lgtm
7 years, 3 months ago (2013-09-03 15:47:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/23745007/1
7 years, 3 months ago (2013-09-05 01:53:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82949
7 years, 3 months ago (2013-09-05 02:52:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/23745007/1
7 years, 3 months ago (2013-09-06 03:09:33 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-06 05:09:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/23745007/1
7 years, 3 months ago (2013-09-06 06:37:19 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:00:49 UTC) #10
Message was sent while issue was closed.
Change committed as 221637

Powered by Google App Engine
This is Rietveld 408576698