chrome/browser/extensions/extension_keybinding_registry.cc - Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_registry.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/extension_protocols_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_keybinding_registry.cc

diff --git a/chrome/browser/extensions/extension_keybinding_registry.cc b/chrome/browser/extensions/extension_keybinding_registry.cc

index 4a87ddd7b979d973fbe65aa169c1bddb39cf659d..43ad281e21cc895bb49564a39179c0040a214a04 100644

--- a/chrome/browser/extensions/extension_keybinding_registry.cc

+++ b/chrome/browser/extensions/extension_keybinding_registry.cc

@@ -11,8 +11,8 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/extension_set.h"

+#include "extensions/common/manifest_constants.h"

namespace extensions {

@@ -49,9 +49,9 @@ void ExtensionKeybindingRegistry::Init() {

bool ExtensionKeybindingRegistry::ShouldIgnoreCommand(

const std::string& command) const {

- return command == extension_manifest_values::kPageActionCommandEvent ||

- command == extension_manifest_values::kBrowserActionCommandEvent ||

- command == extension_manifest_values::kScriptBadgeCommandEvent;

+ return command == manifest_values::kPageActionCommandEvent ||

+ command == manifest_values::kBrowserActionCommandEvent ||

+ command == manifest_values::kScriptBadgeCommandEvent;

}

void ExtensionKeybindingRegistry::CommandExecuted(

« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/extension_protocols_unittest.cc » ('j') | no next file with comments »