Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/extensions/incognito_handler.cc

Issue 23744004: Move the rest of extension_manifest_constants to top-level extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/incognito_handler.h" 5 #include "chrome/common/extensions/incognito_handler.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/extension.h" 10 #include "chrome/common/extensions/extension.h"
11 #include "chrome/common/extensions/extension_manifest_constants.h" 11 #include "extensions/common/manifest_constants.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 namespace keys = manifest_keys; 15 namespace keys = manifest_keys;
16 16
17 IncognitoInfo::IncognitoInfo(bool incognito_split_mode) 17 IncognitoInfo::IncognitoInfo(bool incognito_split_mode)
18 : split_mode(incognito_split_mode) { 18 : split_mode(incognito_split_mode) {
19 } 19 }
20 20
21 IncognitoInfo::~IncognitoInfo() { 21 IncognitoInfo::~IncognitoInfo() {
(...skipping 16 matching lines...) Expand all
38 if (!extension->manifest()->HasKey(keys::kIncognito)) { 38 if (!extension->manifest()->HasKey(keys::kIncognito)) {
39 // Apps default to split mode, extensions default to spanning. 39 // Apps default to split mode, extensions default to spanning.
40 extension->SetManifestData(keys::kIncognito, 40 extension->SetManifestData(keys::kIncognito,
41 new IncognitoInfo(extension->is_app())); 41 new IncognitoInfo(extension->is_app()));
42 return true; 42 return true;
43 } 43 }
44 44
45 bool split_mode = false; 45 bool split_mode = false;
46 std::string incognito_string; 46 std::string incognito_string;
47 if (!extension->manifest()->GetString(keys::kIncognito, &incognito_string)) { 47 if (!extension->manifest()->GetString(keys::kIncognito, &incognito_string)) {
48 *error = ASCIIToUTF16(extension_manifest_errors::kInvalidIncognitoBehavior); 48 *error = ASCIIToUTF16(manifest_errors::kInvalidIncognitoBehavior);
49 return false; 49 return false;
50 } 50 }
51 51
52 if (incognito_string == extension_manifest_values::kIncognitoSplit) 52 if (incognito_string == manifest_values::kIncognitoSplit)
53 split_mode = true; 53 split_mode = true;
54 else if (incognito_string != extension_manifest_values::kIncognitoSpanning) { 54 else if (incognito_string != manifest_values::kIncognitoSpanning) {
55 // If incognito_string == kIncognitoSpanning, it is valid and 55 // If incognito_string == kIncognitoSpanning, it is valid and
56 // split_mode remains false. 56 // split_mode remains false.
57 *error = ASCIIToUTF16(extension_manifest_errors::kInvalidIncognitoBehavior); 57 *error = ASCIIToUTF16(manifest_errors::kInvalidIncognitoBehavior);
58 return false; 58 return false;
59 } 59 }
60 60
61 extension->SetManifestData(keys::kIncognito, new IncognitoInfo(split_mode)); 61 extension->SetManifestData(keys::kIncognito, new IncognitoInfo(split_mode));
62 return true; 62 return true;
63 } 63 }
64 64
65 bool IncognitoHandler::AlwaysParseForType(Manifest::Type type) const { 65 bool IncognitoHandler::AlwaysParseForType(Manifest::Type type) const {
66 return true; 66 return true;
67 } 67 }
68 68
69 const std::vector<std::string> IncognitoHandler::Keys() const { 69 const std::vector<std::string> IncognitoHandler::Keys() const {
70 return SingleKey(keys::kIncognito); 70 return SingleKey(keys::kIncognito);
71 } 71 }
72 72
73 } // namespace extensions 73 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_manifest_constants.cc ('k') | chrome/common/extensions/manifest_handler_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698