Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/password_manager/password_store_x.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_x.h" 5 #include "chrome/browser/password_manager/password_store_x.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/prefs/pref_service.h" 13 #include "base/prefs/pref_service.h"
14 #include "base/stl_util.h" 14 #include "base/stl_util.h"
15 #include "chrome/browser/chrome_notification_types.h" 15 #include "chrome/browser/chrome_notification_types.h"
16 #include "chrome/browser/password_manager/password_store_change.h" 16 #include "chrome/browser/password_manager/password_store_change.h"
17 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
18 #include "components/user_prefs/pref_registry_syncable.h" 18 #include "components/user_prefs/pref_registry_syncable.h"
19 #include "content/public/browser/browser_thread.h" 19 #include "content/public/browser/browser_thread.h"
20 #include "content/public/browser/notification_service.h" 20 #include "content/public/browser/notification_service.h"
21 21
22 using autofill::PasswordForm;
22 using content::BrowserThread; 23 using content::BrowserThread;
23 using std::vector; 24 using std::vector;
24 using content::PasswordForm;
25 25
26 PasswordStoreX::PasswordStoreX(LoginDatabase* login_db, 26 PasswordStoreX::PasswordStoreX(LoginDatabase* login_db,
27 Profile* profile, 27 Profile* profile,
28 NativeBackend* backend) 28 NativeBackend* backend)
29 : PasswordStoreDefault(login_db, profile), 29 : PasswordStoreDefault(login_db, profile),
30 backend_(backend), migration_checked_(!backend), allow_fallback_(false) { 30 backend_(backend), migration_checked_(!backend), allow_fallback_(false) {
31 } 31 }
32 32
33 PasswordStoreX::~PasswordStoreX() {} 33 PasswordStoreX::~PasswordStoreX() {}
34 34
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 } 110 }
111 }; 111 };
112 } // anonymous namespace 112 } // anonymous namespace
113 113
114 void PasswordStoreX::SortLoginsByOrigin(NativeBackend::PasswordFormList* list) { 114 void PasswordStoreX::SortLoginsByOrigin(NativeBackend::PasswordFormList* list) {
115 // In login_database.cc, the query has ORDER BY origin_url. Simulate that. 115 // In login_database.cc, the query has ORDER BY origin_url. Simulate that.
116 std::sort(list->begin(), list->end(), LoginLessThan()); 116 std::sort(list->begin(), list->end(), LoginLessThan());
117 } 117 }
118 118
119 void PasswordStoreX::GetLoginsImpl( 119 void PasswordStoreX::GetLoginsImpl(
120 const content::PasswordForm& form, 120 const autofill::PasswordForm& form,
121 const ConsumerCallbackRunner& callback_runner) { 121 const ConsumerCallbackRunner& callback_runner) {
122 CheckMigration(); 122 CheckMigration();
123 std::vector<content::PasswordForm*> matched_forms; 123 std::vector<autofill::PasswordForm*> matched_forms;
124 if (use_native_backend() && backend_->GetLogins(form, &matched_forms)) { 124 if (use_native_backend() && backend_->GetLogins(form, &matched_forms)) {
125 SortLoginsByOrigin(&matched_forms); 125 SortLoginsByOrigin(&matched_forms);
126 callback_runner.Run(matched_forms); 126 callback_runner.Run(matched_forms);
127 // The native backend may succeed and return no data even while locked, if 127 // The native backend may succeed and return no data even while locked, if
128 // the query did not match anything stored. So we continue to allow fallback 128 // the query did not match anything stored. So we continue to allow fallback
129 // until we perform a write operation, or until a read returns actual data. 129 // until we perform a write operation, or until a read returns actual data.
130 if (matched_forms.size() > 0) 130 if (matched_forms.size() > 0)
131 allow_fallback_ = false; 131 allow_fallback_ = false;
132 } else if (allow_default_store()) { 132 } else if (allow_default_store()) {
133 DCHECK(matched_forms.empty()); 133 DCHECK(matched_forms.empty());
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 } // anonymous namespace 300 } // anonymous namespace
301 301
302 // static 302 // static
303 void PasswordStoreX::SetPasswordsUseLocalProfileId(PrefService* prefs) { 303 void PasswordStoreX::SetPasswordsUseLocalProfileId(PrefService* prefs) {
304 // This method should work on any thread, but we expect the DB thread. 304 // This method should work on any thread, but we expect the DB thread.
305 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 305 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
306 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, 306 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
307 base::Bind(&UISetPasswordsUseLocalProfileId, prefs)); 307 base::Bind(&UISetPasswordsUseLocalProfileId, prefs));
308 } 308 }
309 #endif // !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && defined(OS_POSIX) 309 #endif // !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && defined(OS_POSIX)
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store_x.h ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698