Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3812)

Unified Diff: chrome/browser/chromeos/file_manager/file_tasks.h

Issue 23740004: Files.app: Let the file browser private tasks APIs use the auto-generated helper classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed the test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/file_tasks.h
diff --git a/chrome/browser/chromeos/file_manager/file_tasks.h b/chrome/browser/chromeos/file_manager/file_tasks.h
index b737a75b301ebfd9ab9718c45cfa72d6cec1f457..722d95a43fe5234c1dbbb6da16f16a72230b581e 100644
--- a/chrome/browser/chromeos/file_manager/file_tasks.h
+++ b/chrome/browser/chromeos/file_manager/file_tasks.h
@@ -169,7 +169,7 @@ class FullTaskDescriptor {
const TaskDescriptor& task_descriptor() const { return task_descriptor_; }
// The title of the task.
- const std::string& task_title() { return task_title_; }
+ const std::string& task_title() const { return task_title_; }
// The icon URL for the task (ex. app icon)
const GURL& icon_url() const { return icon_url_; }
@@ -177,20 +177,6 @@ class FullTaskDescriptor {
bool is_default() const { return is_default_; }
void set_is_default(bool is_default) { is_default_ = is_default; }
- // Returns a DictionaryValue representation, which looks like:
- //
- // {
- // "iconUrl": "<app_icon_url>",
- // "isDefault": false,
- // "taskId": "<drive_app_id>|drive|open-with",
- // "title": "Drive App Name (ex. Pixlr Editor)"
- // },
- //
- // "iconUrl" is omitted if icon_url_ is empty.
- //
- // This representation will be used to send task info to the JavaScript.
- scoped_ptr<base::DictionaryValue> AsDictionaryValue() const;
-
private:
TaskDescriptor task_descriptor_;
std::string task_title_;

Powered by Google App Engine
This is Rietveld 408576698