Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 23739005: Replace direct use of DriveIntegrationServiceFactory with drive::util::GetFileSystemByProfile. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Replace direct use of DriveIntegrationServiceFactory with drive::util::GetFileSystemByProfile. DriveIntegrationServiceFactory::GetForProfile will return the instance regardless of whether the Drive is enabled or not. GetFileSystemByProfile will still be looking at enabled state. BUG=284972 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M apps/launcher.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Ben, could you review as an OWNER? Kazuhiro, could you kindly double check? Thank you ...
7 years, 3 months ago (2013-09-05 18:06:00 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-09-06 03:11:02 UTC) #2
benwells
lgtm
7 years, 3 months ago (2013-09-09 05:05:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23739005/1
7 years, 3 months ago (2013-09-09 05:06:18 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 10:28:52 UTC) #5
Message was sent while issue was closed.
Change committed as 221998

Powered by Google App Engine
This is Rietveld 408576698