Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 23739003: Remove getNodesInCommand debug method from Editing commands (Closed)

Created:
7 years, 3 months ago by esprehn
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove getNodesInCommand debug method from Editing commands These methods appear to be for debugging and nothing ever calls them. It's a bit strange to want a hash set of every node all commands in the hierachy touched as well since they're not ordered so the set doesn't really tell you what the command did anyway. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -175 lines) Patch
M Source/core/editing/AppendNodeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/AppendNodeCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/editing/EditCommand.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/EditCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/editing/SetSelectionCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/SplitElementCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
esprehn
7 years, 3 months ago (2013-09-04 00:50:58 UTC) #1
ojan
lgtm
7 years, 3 months ago (2013-09-04 00:54:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23739003/1
7 years, 3 months ago (2013-09-04 00:54:49 UTC) #3
eseidel
lgtm
7 years, 3 months ago (2013-09-04 01:01:42 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 04:42:09 UTC) #5
Message was sent while issue was closed.
Change committed as 157191

Powered by Google App Engine
This is Rietveld 408576698