Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: chrome/browser/app_controller_mac_browsertest.mm

Issue 23737003: Mac: Fix window raising for multiple desktops (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Manually switch spaces for app shims Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/app_controller_mac_browsertest.mm
diff --git a/chrome/browser/app_controller_mac_browsertest.mm b/chrome/browser/app_controller_mac_browsertest.mm
index 224374d9ad2518fe38d25f33f56858405fe558df..641d9cbf27e18494cbc852c8de73f274a705457a 100644
--- a/chrome/browser/app_controller_mac_browsertest.mm
+++ b/chrome/browser/app_controller_mac_browsertest.mm
@@ -48,9 +48,11 @@ IN_PROC_BROWSER_TEST_F(AppControllerPlatformAppBrowserTest,
base::scoped_nsobject<AppController> ac([[AppController alloc] init]);
NSUInteger old_window_count = [[NSApp windows] count];
EXPECT_EQ(1u, active_browser_list_->size());
- BOOL result = [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:YES];
+ [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:YES];
+ // We do not EXPECT_TRUE the result here because the method
+ // deminiaturizes windows manually rather than return YES and have
+ // AppKit do it.
- EXPECT_TRUE(result);
EXPECT_EQ(old_window_count, [[NSApp windows] count]);
EXPECT_EQ(1u, active_browser_list_->size());
}

Powered by Google App Engine
This is Rietveld 408576698