Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: apps/app_shim/extension_app_shim_handler_mac.cc

Issue 23737003: Mac: Fix window raising for multiple desktops (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Manually switch spaces for app shims Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | ui/base/cocoa/focus_window_set.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_shim/extension_app_shim_handler_mac.cc
diff --git a/apps/app_shim/extension_app_shim_handler_mac.cc b/apps/app_shim/extension_app_shim_handler_mac.cc
index a45eccb775e605498d04f5c921e3a71cf4da1b64..7e26027572aaf750acc46bc8e73b3a63defe52f0 100644
--- a/apps/app_shim/extension_app_shim_handler_mac.cc
+++ b/apps/app_shim/extension_app_shim_handler_mac.cc
@@ -297,7 +297,11 @@ void ExtensionAppShimHandler::OnShimFocus(Host* host,
native_windows.insert((*it)->GetNativeWindow());
}
if (!native_windows.empty()) {
- ui::FocusWindowSet(native_windows);
+ // Allow workspace switching. For the browser process, we can
+ // reasonably rely on OS X to switch spaces for us and honor
+ // relevant user settings. But shims don't have windows, so we
+ // have to do it ourselves.
+ ui::FocusWindowSet(native_windows, true);
return;
}
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | ui/base/cocoa/focus_window_set.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698