Issue 23737002: Use sequenced blocking pool task to create PNaCl's nexe temp file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23737002: Use sequenced blocking pool task to create PNaCl's nexe temp file (Closed)

Created:
7 years, 3 months ago by Derek Schuff

Modified:
7 years, 3 months ago

Reviewers:
jvoung (off chromium)

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use sequenced blocking pool task to create PNaCl's nexe temp files This isn't necessary in the browser since if there are 2 requests for the same translation we don't care which one wins, (i.e. which one gets the temp file and does the translation and which one blocks to wait) but the unit tests do care because they try to hit particular corner cases. This is why they were flaky. So just always sequence the temp file creation, which will have minimal cost in practice. Also re-enable the disabled tests. R=jvoung@chromium.org BUG=272492 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220457

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -47 lines)			Patch
M	chrome/browser/nacl_host/pnacl_host.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/nacl_host/pnacl_host.cc	View	1	3 chunks	+37 lines, -36 lines	0 comments	Download
M	chrome/browser/nacl_host/pnacl_host_unittest.cc	View	2 3	5 chunks	+5 lines, -10 lines	0 comments	Download