Clean up sparse_histogram.h header

Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bartfab@chromium.org,mad@chromium.org,rogerta@chromium.org,gab@chromium.org,boliu@chromium.org,estade@chromium.org,juliatuttle@chromium.org,vmiura@chromium.org,dewittj@chromium.org,hajimehoshi@chromium.org,ncarter@chromium.orgsvaldez@chromium.org,pkasting@chromium.org,sehr@chromium.org,mkwst@chromium.org,treib@chromium.org,marcheu@chromium.org,zea@chromium.org,kinaba@chromium.org,torne@chromium.org,mtomasz@chromium.org,ccameron@chromium.org,eugenebut@chromium.org,dimich@chromium.org,mcasas@chromium.org,mek@chromium.org,agl@chromium.org

Committed: https://crrev.com/ddaa36a20e8d517fb591f034fca5bc1b9a2d4d9d
Cr-Commit-Position: refs/heads/master@{#426131}

[nikunjb1, 2016-09-27 00:58:18]

Description was changed from

==========
Clean up sparse_histogram.h header
Move UMA_HSITOGRAM_SPARSE_SLOWLY to histogram_macros.h
Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h
BUG=650371
==========

to

==========
Clean up sparse_histogram.h header
Move UMA_HSITOGRAM_SPARSE_SLOWLY to histogram_macros.h
Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h
BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[nikunjb1, 2016-09-27 23:50:30]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 23:50:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:59:49]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[nikunjb1, 2016-09-28 00:35:28]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 00:36:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 00:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 00:52:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[nikunjb1, 2016-09-28 00:59:15]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 00:59:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 01:03:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nikunjb1, 2016-09-28 01:22:30]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 01:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 01:32:18]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nikunjb1, 2016-09-28 18:32:27]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 18:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 18:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:41:01]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[nikunjb1, 2016-09-28 18:52:20]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 18:52:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 20:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 20:19:33]

Dry run: This issue passed the CQ dry run.

[nikunjb1, 2016-09-28 21:37:37]

Description was changed from

==========
Clean up sparse_histogram.h header
Move UMA_HSITOGRAM_SPARSE_SLOWLY to histogram_macros.h
Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h
BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clean up sparse_histogram.h header
Move UMA_HSITOGRAM_SPARSE_SLOWLY to histogram_macros.h
Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h
BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[nikunjb1, 2016-09-28 21:37:38]

nikunjb@chromium.org changed reviewers:
+ asvitkine@google.com, rkaplow@chromium.org

[nikunjb1, 2016-09-29 18:31:10]

Move sparse histogram macros to histogram_macros.h

[rkaplow, 2016-09-30 14:55:00]

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
File base/metrics/histogram_macros.h (right):

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:227: // Sparse histograms are well suited for
recording counts of exact sample values
Can you keep the formatting I added in the rest of the file? I.e. sections
grouped with 
//------------------------------------------------------------------------------
headers

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:230: // The implementation uses a lock and a
map, whereas other histogram types use a
I think some of this technical detail could be reduced - this should just
explain when it should be used (sparse data) and how it is used

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:236: // UMA_HISTOGRAM_ENUMERATION would be
better suited for a smaller range of
Don't need to document ENUM here I think. If we wanted to mention this - maybe
put this near the enum macro

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:245: // pre-allocated vector of slots once the
fleet gets to version 4 or 5 or 10.
I'm not even sure what this comment means when it says "the fleet gets to
version 4 or 5..."

[nikunjb1, 2016-10-03 22:25:42]

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
File base/metrics/histogram_macros.h (right):

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:227: // Sparse histograms are well suited for
recording counts of exact sample values
On 2016/09/30 14:55:00, rkaplow wrote:
> Can you keep the formatting I added in the rest of the file? I.e. sections
> grouped with 
>
//------------------------------------------------------------------------------
> headers
> 

Done.

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:230: // The implementation uses a lock and a
map, whereas other histogram types use a
On 2016/09/30 14:55:00, rkaplow wrote:
> I think some of this technical detail could be reduced - this should just
> explain when it should be used (sparse data) and how it is used

Done. Moved implementation comments to internals.

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:236: // UMA_HISTOGRAM_ENUMERATION would be
better suited for a smaller range of
On 2016/09/30 14:55:00, rkaplow wrote:
> Don't need to document ENUM here I think. If we wanted to mention this - maybe
> put this near the enum macro

Done.

https://codereview.chromium.org/2373523003/diff/80001/base/metrics/histogram_...
base/metrics/histogram_macros.h:245: // pre-allocated vector of slots once the
fleet gets to version 4 or 5 or 10.
On 2016/09/30 14:55:00, rkaplow wrote:
> I'm not even sure what this comment means when it says "the fleet gets to
> version 4 or 5..."

Done. Added clarification.

[nikunjb1, 2016-10-04 00:00:11]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:01:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:06:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nikunjb1, 2016-10-04 00:10:35]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:11:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 01:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 01:53:19]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-10-04 17:04:51]

lgtm

https://codereview.chromium.org/2373523003/diff/120001/base/metrics/histogram...
File base/metrics/histogram_macros_internal.h (right):

https://codereview.chromium.org/2373523003/diff/120001/base/metrics/histogram...
base/metrics/histogram_macros_internal.h:133: // The implementation  more costly
to add values to, and each value
is more constly

[nikunjb1, 2016-10-04 19:16:44]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 19:17:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nikunjb1, 2016-10-04 21:22:35]

Description was changed from

==========
Clean up sparse_histogram.h header
Move UMA_HSITOGRAM_SPARSE_SLOWLY to histogram_macros.h
Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h
BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Adding cpu@ (from src/OWNERS) as reviewer because this CL is touching a large
number of files from various OWNERS (Although the change in most of these files
are trivial).

Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h

All Changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[nikunjb1, 2016-10-04 21:22:35]

nikunjb@chromium.org changed reviewers:
+ cpu@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:24:22]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[nikunjb1, 2016-10-05 23:52:35]

Adding OWNERS from rc/OWNERS because the change touch .cc files across multiple
projects.

https://codereview.chromium.org/2373523003/diff/120001/base/metrics/histogram...
File base/metrics/histogram_macros_internal.h (right):

https://codereview.chromium.org/2373523003/diff/120001/base/metrics/histogram...
base/metrics/histogram_macros_internal.h:133: // The implementation  more costly
to add values to, and each value
On 2016/10/04 17:04:51, rkaplow wrote:
> is more constly

Done.

[rkaplow, 2016-10-18 14:35:06]

On 2016/10/05 23:52:35, nikunjb1 wrote:
> Adding OWNERS from rc/OWNERS because the change touch .cc files across
multiple
> projects.
> 
>
https://codereview.chromium.org/2373523003/diff/120001/base/metrics/histogram...
> File base/metrics/histogram_macros_internal.h (right):
> 
>
https://codereview.chromium.org/2373523003/diff/120001/base/metrics/histogram...
> base/metrics/histogram_macros_internal.h:133: // The implementation  more
costly
> to add values to, and each value
> On 2016/10/04 17:04:51, rkaplow wrote:
> > is more constly
> 
> Done.

In this case you should add each owner for each API user to the reviewer line
and the TBR line. I think you can then commit the code

[asanka, 2016-10-18 15:21:26]

Drive by:

Could you make sure the first line of the CL description is a brief summary of
what the CL does? You could remove the 'Adding ... ' line and get most of the
way there. Justification for adding reviewers don't really need to be in the CL
description.

[nikunjb1, 2016-10-18 21:21:57]

Description was changed from

==========
Adding cpu@ (from src/OWNERS) as reviewer because this CL is touching a large
number of files from various OWNERS (Although the change in most of these files
are trivial).

Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Modifying include in the repo which point to sparse_histogram.h to
histogram_macros.h

All Changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[nikunjb1, 2016-10-18 21:51:26]

The CQ bit was checked by nikunjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 21:51:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nikunjb1, 2016-10-18 21:52:59]

On 2016/10/18 15:21:26, asanka wrote:
> Drive by:
> 
> Could you make sure the first line of the CL description is a brief summary of
> what the CL does? You could remove the 'Adding ... ' line and get most of the
> way there. Justification for adding reviewers don't really need to be in the
CL
> description.

Done. Once CQ passes, I will submit the CL with TBR for owners in files outside
base/metrics

[nikunjb1, 2016-10-18 22:15:48]

nikunjb@chromium.org changed reviewers:
- cpu@chromium.org

[nikunjb1, 2016-10-18 22:50:31]

nikunjb@chromium.org changed reviewers:
+ agl@chromium.org, bartfab@chromium.org, bbudge@chromium.org,
boliu@chromium.org, ccameron@chromium.org, dcheng@chromium.org,
dewittj@chromium.org, dimich@chromium.org, estade@chromium.org,
eugenebut@chromium.org, gab@chromium.org, hajimehoshi@chromium.org,
juliatuttle@chromium.org, kinaba@chromium.org, mad@chromium.org,
marcheu@chromium.org, mcasas@chromium.org, mek@chromium.org, mkwst@chromium.org,
mtomasz@chromium.org, nick@chromium.org, pkasting@chromium.org,
rockot@chromium.org, rogerta@chromium.org, satorux@chromium.org,
scheib@chromium.org, sehr@chromium.org, shess@chromium.org, slan@chromium.org,
svaldez@chromium.org, tapted@chromium.org, tedchoc@chromium.org,
torne@chromium.org, treib@chromium.org, vakh@chromium.org, vmiura@chromium.org,
xhwang@chromium.org, zea@chromium.org

[nikunjb1, 2016-10-18 22:50:32]

Adding reviewers from OWNERS of files touched in the CL.

Note that the only change is macros from sparse_histogram.h is moved to
histogram_macros.h. So the changes are to replace sparse_histogram.h with
histogram_macros.h

[xhwang, 2016-10-18 22:59:09]

On 2016/10/18 22:50:32, nikunjb1 wrote:
> Adding reviewers from OWNERS of files touched in the CL.
> 
> Note that the only change is macros from sparse_histogram.h is moved to
> histogram_macros.h. So the changes are to replace sparse_histogram.h with
> histogram_macros.h

I feel you can just TBR once you get approval for the move instead of adding all
these owners to review.

That being said, media/* LGTM

[vakh (use Gerrit instead), 2016-10-18 23:03:57]

lgtm

for components/safe_browsing_db/

[tapted, 2016-10-18 23:05:03]

web_app_mac.mm lgtm

[satorux1, 2016-10-18 23:07:34]

c/b/chromeos and components/drive lgtm

[Ted C, 2016-10-18 23:28:36]

On 2016/10/18 23:07:34, satorux1 wrote:
> c/b/chromeos and components/drive lgtm

android lgtm

[scheib, 2016-10-18 23:30:24]

LGTM

[commit-bot: I haz the power, 2016-10-18 23:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:33:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Scott Hess - ex-Googler, 2016-10-18 23:36:05]

lgtm

[Ken Rockot(use gerrit already), 2016-10-18 23:43:03]

lgtm

[slan, 2016-10-18 23:44:46]

On 2016/10/18 23:43:03, Ken Rockot wrote:
> lgtm

rs lgtm

[dcheng, 2016-10-18 23:46:25]

//base LGTM

[bbudge, 2016-10-19 00:06:08]

lgtm

[nikunjb1, 2016-10-19 00:11:42]

Description was changed from

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bartfab@chromium.org,mad@chromium.org,rogerta@chromium.org,gab@chromium.o...
==========

[kinaba, 2016-10-19 00:16:05]

lgtm

[nikunjb1, 2016-10-19 00:36:16]

The CQ bit was checked by nikunjb@chromium.org

[nikunjb1, 2016-10-19 00:36:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2373523003/#ps160001
(title: "Rebase update on Oct 18")

[Peter Kasting, 2016-10-19 01:17:48]

Some hopefully-useful tips:

For purely-mechanical changes, it's not only OK but preferable to TBR individual
OWNERS if needed, or get approval from one top-level OWNER.  This will hopefully
save you time, and make reviewers' lives easier too.

When you do need multiple people to actually review, please always say exactly
what each one needs to look at (and avoid overlap unless you really need
multiple reviewers to look at something).  For example, there are dozens of
files and reviewers here and I'm in ~30 OWNERS files in Chromium.  Because of
those factors, I'm not going to try to figure out what combination of files you
meant for me to review, but I'm happy to look at specific things when told to do
so.

[commit-bot: I haz the power, 2016-10-19 01:33:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 04:13:31]

Description was changed from

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bartfab@chromium.org,mad@chromium.org,rogerta@chromium.org,gab@chromium.o...
==========

to

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bartfab@chromium.org,mad@chromium.org,rogerta@chromium.org,gab@chromium.o...
==========

[commit-bot: I haz the power, 2016-10-19 04:13:34]

Committed patchset #9 (id:160001)

[ncarter (slow), 2016-10-19 17:22:55]

content/ and chrome/browser/bad_message lgtm

[dewittj, 2016-10-19 17:26:37]

c/b/notifications lgtm

[gab, 2016-10-19 18:26:25]

On 2016/10/19 01:17:48, Peter Kasting wrote:
> Some hopefully-useful tips:
> 
> For purely-mechanical changes, it's not only OK but preferable to TBR
individual
> OWNERS if needed, or get approval from one top-level OWNER.  This will
hopefully
> save you time, and make reviewers' lives easier too.
> 
> When you do need multiple people to actually review, please always say exactly
> what each one needs to look at (and avoid overlap unless you really need
> multiple reviewers to look at something).  For example, there are dozens of
> files and reviewers here and I'm in ~30 OWNERS files in Chromium.  Because of
> those factors, I'm not going to try to figure out what combination of files
you
> meant for me to review, but I'm happy to look at specific things when told to
do
> so.

Same.

[commit-bot: I haz the power, 2016-10-21 13:06:17]

Description was changed from

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bartfab@chromium.org,mad@chromium.org,rogerta@chromium.org,gab@chromium.o...
==========

to

==========
Clean up sparse_histogram.h header by moving UMA_HSITOGRAM_SPARSE_SLOWLY to
histogram_macros.h

Also modifying include in the repo which points to sparse_histogram.h to
histogram_macros.h

All changes to file not in base/metrics is for using histogram_macros.h instead
of sparse_histogram.h

We are doing this to consolidate header files and cleanup base/metrics
externally usable histogram macros.

BUG=650371
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bartfab@chromium.org,mad@chromium.org,rogerta@chromium.org,gab@chromium.o...

Committed: https://crrev.com/ddaa36a20e8d517fb591f034fca5bc1b9a2d4d9d
Cr-Commit-Position: refs/heads/master@{#426131}
==========

[commit-bot: I haz the power, 2016-10-21 13:06:20]

Patchset 9 (id:??) landed as
https://crrev.com/ddaa36a20e8d517fb591f034fca5bc1b9a2d4d9d
Cr-Commit-Position: refs/heads/master@{#426131}