Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 23734005: [chromedriver] Fix a confusing error message. (Closed)

Created:
7 years, 3 months ago by chrisgao (Use stgao instead)
Modified:
7 years, 3 months ago
Reviewers:
kkania
CC:
chromium-reviews, vsevik, kkania, frankf, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

[chromedriver] Fix a confusing error message. When the target window was closed, new window commands will trigger reconnection to DevTools. Thus, the original message is misleading. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisgao (Use stgao instead)
7 years, 3 months ago (2013-09-08 03:37:11 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-09 17:46:26 UTC) #2
kkania
lgtm
7 years, 3 months ago (2013-09-09 17:47:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/23734005/1
7 years, 3 months ago (2013-09-09 17:51:28 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 21:41:53 UTC) #5
Message was sent while issue was closed.
Change committed as 222100

Powered by Google App Engine
This is Rietveld 408576698