Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 23734003: Add the text direction to the WebScrollbar interface. (Closed)

Created:
7 years, 3 months ago by tony
Modified:
7 years, 3 months ago
Reviewers:
jamesr
CC:
blink-reviews, jamesr, eae+blinkwatch, tommyw+watchlist_chromium.org, abarth-chromium, dglazkov+blink, jeez
Visibility:
Public.

Description

Add the text direction to the WebScrollbar interface. When drawing thinning scrollbars, we'll need this information. The text direction is always LTR for horizontal scrollbars. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156888

Patch Set 1 #

Patch Set 2 : less memory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M Source/core/platform/ScrollableArea.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/platform/ScrollableArea.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/platform/Scrollbar.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/platform/Scrollbar.cpp View 1 2 chunks +8 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/support/WebScrollbarImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/platform/chromium/support/WebScrollbarImpl.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/web/WebPluginScrollbarImpl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/web/WebPluginScrollbarImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/platform/WebScrollbar.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tony
7 years, 3 months ago (2013-08-28 23:09:43 UTC) #1
jamesr
It feels a bit awkward to use text direction to talk about scrollbars, since scrollbars ...
7 years, 3 months ago (2013-08-28 23:11:41 UTC) #2
tony
On 2013/08/28 23:11:41, jamesr wrote: > It feels a bit awkward to use text direction ...
7 years, 3 months ago (2013-08-28 23:15:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/23734003/1
7 years, 3 months ago (2013-08-28 23:15:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/23734003/13001
7 years, 3 months ago (2013-08-29 00:21:18 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 01:58:54 UTC) #6
Message was sent while issue was closed.
Change committed as 156888

Powered by Google App Engine
This is Rietveld 408576698