Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 23731011: Removed chrome.rtcPrivate API. (Closed)

Created:
7 years, 3 months ago by zel
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Removed chrome.rtcPrivate API. BUG=247263 TEST=removed related tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224873

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -280 lines) Patch
D chrome/browser/extensions/api/rtc_private/rtc_private_api.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/extensions/api/rtc_private/rtc_private_api.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/extensions/api/rtc_private/rtc_private_apitest.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 3 chunks +0 lines, -3 lines 0 comments Download
D chrome/common/extensions/api/rtc_private.idl View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
zel
...we should have a better solution in the pipeline now for what this unused API ...
7 years, 3 months ago (2013-09-19 19:07:11 UTC) #1
rkc
lgtm
7 years, 3 months ago (2013-09-19 19:08:58 UTC) #2
zel
+mpcomplete@ instead of asargent@
7 years, 3 months ago (2013-09-19 19:53:20 UTC) #3
not at google - send to devlin
lgtm
7 years, 3 months ago (2013-09-20 23:09:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/23731011/1
7 years, 3 months ago (2013-09-20 23:32:16 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/api.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-20 23:32:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/23731011/9001
7 years, 3 months ago (2013-09-21 17:48:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=81680
7 years, 3 months ago (2013-09-23 02:29:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/23731011/48001
7 years, 3 months ago (2013-09-23 19:00:48 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=201369
7 years, 3 months ago (2013-09-24 00:30:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/23731011/48001
7 years, 3 months ago (2013-09-24 00:44:26 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 03:18:17 UTC) #12
Message was sent while issue was closed.
Change committed as 224873

Powered by Google App Engine
This is Rietveld 408576698