Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Issue 23727002: Add --disable-pnacl to about://flags (Closed)

Created:
7 years, 3 months ago by sehr
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add --disable-pnacl to about://flags Disabling pnacl was removed from about://flags because the previous implementation produced empty command line flags. https://chromiumcodereview.appspot.com/23464011/ Add the ability to set it, without producing empty flags. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sehr
PTAL.
7 years, 3 months ago (2013-08-28 18:24:09 UTC) #1
jvoung (off chromium)
Set BUG=280204, and link to which CL removed this so that the commit history is ...
7 years, 3 months ago (2013-08-28 19:46:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/23727002/1
7 years, 3 months ago (2013-08-28 21:04:20 UTC) #3
pastarmovj
lgtm
7 years, 3 months ago (2013-08-29 08:05:36 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 10:02:57 UTC) #5
Message was sent while issue was closed.
Change committed as 220255

Powered by Google App Engine
This is Rietveld 408576698