Show non-incognito browser in front of incognito browser when signing in from bookmark bubble.

Show non-incognito browser in front of incognito browser when signing in from bookmark bubble.

When sign in is initiated from the bookmark bubble in an incognito
browser, the sign in page is not displayed in the browser provided to
chrome::ShowBrowserSignin() but in a new/existing non-incognito browser.
BookmarkBubbleSignInDelegate was not aware of that and called Show()
on the wrong browser.

This call was unnecessary because chrome::ShowBrowserSignin() already
make it on the right browser. I removed the unnecessary call.

BUG=282305
TEST=
Pre-condition: Make sure you are not signed in to Chrome.
1.Launch Chrome, open 'Incognito window' from hot-dog menu and navigate to www.google.com.
2.Click on bookmark icon(star) in omnibox and click on 'Sign in' link of bookmark dialog box.
Expected result: Sign in page is displayed in a non-incognito browser.
This browser is displayed in front of the incognito browser.
R=rogerta

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221212

[fdoray, 2013-08-31 00:31:54]

Could you review this CL? Thanks.

[tfarina, 2013-08-31 01:32:05]

https://codereview.chromium.org/23726016/diff/3001/chrome/browser/ui/bookmark...
File chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc
(right):

https://codereview.chromium.org/23726016/diff/3001/chrome/browser/ui/bookmark...
chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc:27:
virtual void Show() OVERRIDE {
can this be in private section?

also

// TestBrowserWindow:

https://codereview.chromium.org/23726016/diff/3001/chrome/browser/ui/bookmark...
chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc:32: int
show_count_;
please, make this private, add a public getter for it and private:
DISALLOW_COPY_AND_ASSIGN.

[fdoray, 2013-09-03 01:38:56]

+sky@: Owner

Could you review the CL? Thanks.

https://codereview.chromium.org/23726016/diff/3001/chrome/browser/ui/bookmark...
File chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc
(right):

https://codereview.chromium.org/23726016/diff/3001/chrome/browser/ui/bookmark...
chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc:27:
virtual void Show() OVERRIDE {
On 2013/08/31 01:32:05, tfarina wrote:
> can this be in private section?
> 
> also
> 
> // TestBrowserWindow:

Done.

https://codereview.chromium.org/23726016/diff/3001/chrome/browser/ui/bookmark...
chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc:32: int
show_count_;
On 2013/08/31 01:32:05, tfarina wrote:
> please, make this private, add a public getter for it and private:
> DISALLOW_COPY_AND_ASSIGN.

Done.

[Roger Tawa OOO till Jul 10th, 2013-09-03 15:19:20]

lgtm

[sky, 2013-09-03 16:23:50]

LGTM

[commit-bot: I haz the power, 2013-09-03 23:13:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fdoray@chromium.org/23726016/9001

[commit-bot: I haz the power, 2013-09-04 00:00:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-04 01:21:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fdoray@chromium.org/23726016/13001

[commit-bot: I haz the power, 2013-09-04 17:07:28]

Change committed as 221212