Remove old accessibility enums, finish renaming public interface.

Remove old accessibility enums, finish renaming public interface.

This is the third step in a sequence of patches to refactor
Blink accessibility enums to be able to use them in Chromium.

This step finishes renaming the public interface. Subsequent
changes will continue to rename and refactor Blink
accessibility code to be more consistent as well.

Step 1 (Blink): https://chromiumcodereview.appspot.com/22331005
Step 2 (Chromium): https://codereview.chromium.org/23651003

BUG=269034
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157398

[aboxhall, 2013-09-03 16:26:23]

lgtm

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
Source/web/ChromeClientImpl.cpp:801: void
ChromeClientImpl::postAccessibilityNotification(AccessibilityObject* obj,
AXObjectCache::AXNotification notification)
Should we s/notification/event/ here at any point?

https://codereview.chromium.org/23726007/diff/6001/public/web/WebAXObject.h
File public/web/WebAXObject.h (right):

https://codereview.chromium.org/23726007/diff/6001/public/web/WebAXObject.h#n...
public/web/WebAXObject.h:2: * Copyright (C) 2009 Google Inc. All rights
reserved.
This is a bit awkward: it's not considered a rename of WebAccessibilityObject.h
because of the shim. Do we care?

[jamesr, 2013-09-03 21:52:41]

lgtm, but this also points out a lot of things that are still inconsistent. 
Please don't leave things in an inconsistent state for longer than necessary.

https://codereview.chromium.org/23726007/diff/6001/Source/testing/runner/Acce...
File Source/testing/runner/AccessibilityUIElementChromium.h (right):

https://codereview.chromium.org/23726007/diff/6001/Source/testing/runner/Acce...
Source/testing/runner/AccessibilityUIElementChromium.h:45: virtual
AccessibilityUIElement* getOrCreate(const WebKit::WebAXObject&) = 0;
AccessibilityUIElement ... WebAXObject

The inconsistency here is not great.  Are you planning to continue the AXFoo
naming convention through this part of the code as well?

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
Source/web/ChromeClientImpl.cpp:807:
m_webView->client()->postAccessibilityEvent(WebAXObject(obj),
toWebAXEvent(notification));
another inconsistency:

postAccessibilityEvent ... WebAXEvent

is an AccessibilityEvent or an AXEvent?

https://codereview.chromium.org/23726007/diff/6001/Source/web/WebDocument.cpp
File Source/web/WebDocument.cpp (right):

https://codereview.chromium.org/23726007/diff/6001/Source/web/WebDocument.cpp...
Source/web/WebDocument.cpp:253: WebAXObject WebDocument::accessibilityObject()
const
AXObject or accessibilityObject?

[dmazzoni, 2013-09-06 19:53:32]

I definitely plan to finish the renaming. I'll clarify the description of this
change to make it clear that this step finishes the renaming of the *public*
interface, and I will follow up right away with changes to improve naming
consistency within Blink.

https://codereview.chromium.org/23726007/diff/6001/Source/testing/runner/Acce...
File Source/testing/runner/AccessibilityUIElementChromium.h (right):

https://codereview.chromium.org/23726007/diff/6001/Source/testing/runner/Acce...
Source/testing/runner/AccessibilityUIElementChromium.h:45: virtual
AccessibilityUIElement* getOrCreate(const WebKit::WebAXObject&) = 0;
On 2013/09/03 21:52:42, jamesr wrote:
> AccessibilityUIElement ... WebAXObject
> 
> The inconsistency here is not great.  Are you planning to continue the AXFoo
> naming convention through this part of the code as well?

Even before, AccessibilityUIElement was a confusing name.

I think something like WebAXObjectWrapper or WebAXObjectProxy would be better.

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
Source/web/ChromeClientImpl.cpp:801: void
ChromeClientImpl::postAccessibilityNotification(AccessibilityObject* obj,
AXObjectCache::AXNotification notification)
On 2013/09/03 16:26:23, aboxhall wrote:
> Should we s/notification/event/ here at any point?

Agreed.

https://codereview.chromium.org/23726007/diff/6001/Source/web/ChromeClientImp...
Source/web/ChromeClientImpl.cpp:807:
m_webView->client()->postAccessibilityEvent(WebAXObject(obj),
toWebAXEvent(notification));
On 2013/09/03 21:52:42, jamesr wrote:
> another inconsistency:
> 
> postAccessibilityEvent ... WebAXEvent
> 
> is an AccessibilityEvent or an AXEvent?

I prefer postAccessibilityEvent, but not strongly

https://codereview.chromium.org/23726007/diff/6001/Source/web/WebDocument.cpp
File Source/web/WebDocument.cpp (right):

https://codereview.chromium.org/23726007/diff/6001/Source/web/WebDocument.cpp...
Source/web/WebDocument.cpp:253: WebAXObject WebDocument::accessibilityObject()
const
On 2013/09/03 21:52:42, jamesr wrote:
> AXObject or accessibilityObject?

Agreed, this will be axObject().

https://codereview.chromium.org/23726007/diff/6001/public/web/WebAXObject.h
File public/web/WebAXObject.h (right):

https://codereview.chromium.org/23726007/diff/6001/public/web/WebAXObject.h#n...
public/web/WebAXObject.h:2: * Copyright (C) 2009 Google Inc. All rights
reserved.
On 2013/09/03 16:26:23, aboxhall wrote:
> This is a bit awkward: it's not considered a rename of
WebAccessibilityObject.h
> because of the shim. Do we care?

The rename detection did a particularly poor job here. All I can do is upload
without rename detection.

[commit-bot: I haz the power, 2013-09-06 21:20:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23726007/15001

[commit-bot: I haz the power, 2013-09-06 23:51:04]

Change committed as 157398