Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 23724020: Disable unittests that depends on OpenSSL when use_openssl==0 (Closed)

Created:
7 years, 3 months ago by robertn
Modified:
7 years, 3 months ago
Reviewers:
agl, yhirano
CC:
chromium-reviews, cbentzel+watch_chromium.org, Mostyn Bramley-Moore, Daniel Bratell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable unittests that depends on OpenSSL when use_openssl==0 These unittests include headers that includes openssl/ssl.h (sm_connection.h). For platforms that don't have access to OpenSSL this won't work. BUG=23724020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223893

Patch Set 1 #

Total comments: 1

Patch Set 2 : Exclude all flip server files when OpenSSL is disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/net.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
robertn
7 years, 3 months ago (2013-09-09 10:14:32 UTC) #1
yhirano
https://codereview.chromium.org/23724020/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/23724020/diff/1/net/net.gyp#newcode2003 net/net.gyp:2003: 'tools/flip_server/http_interface_test.cc', I think you can exclude all files in ...
7 years, 3 months ago (2013-09-09 11:11:06 UTC) #2
robertn
On 2013/09/09 11:11:06, yhirano wrote: > https://codereview.chromium.org/23724020/diff/1/net/net.gyp > File net/net.gyp (right): > > https://codereview.chromium.org/23724020/diff/1/net/net.gyp#newcode2003 > ...
7 years, 3 months ago (2013-09-09 12:04:05 UTC) #3
yhirano
lgtm
7 years, 3 months ago (2013-09-09 12:45:42 UTC) #4
robertn
On 2013/09/09 12:45:42, yhirano wrote: > lgtm Thanks, do I just check the commit-checkbox now ...
7 years, 3 months ago (2013-09-09 13:32:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertn@opera.com/23724020/5001
7 years, 3 months ago (2013-09-09 13:34:30 UTC) #6
yhirano
> do I just check the commit-checkbox now to get it merged? (First time submitting ...
7 years, 3 months ago (2013-09-09 13:40:39 UTC) #7
robertn
On 2013/09/09 13:40:39, yhirano wrote: > > do I just check the commit-checkbox now to ...
7 years, 3 months ago (2013-09-09 13:42:23 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24405
7 years, 3 months ago (2013-09-09 13:48:19 UTC) #9
robertn
@agl: Does this look good to you?
7 years, 3 months ago (2013-09-11 08:20:30 UTC) #10
robertn
On 2013/09/11 08:20:30, robertn wrote: > @agl: Does this look good to you? Ping
7 years, 3 months ago (2013-09-18 13:16:51 UTC) #11
agl
lgtm
7 years, 3 months ago (2013-09-18 13:34:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertn@opera.com/23724020/5001
7 years, 3 months ago (2013-09-18 13:34:20 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 17:19:07 UTC) #14
Message was sent while issue was closed.
Change committed as 223893

Powered by Google App Engine
This is Rietveld 408576698