Rework OpaqueBrowserFrameViewLayout.

Rework OpaqueBrowserFrameViewLayout.

Instead of having absolute positions for most elements, Layout() now
works one by one, packing the View in question onto either the left or
right. This should allow us to configure whether window control buttons
are being inserted on the left or the right.

BUG=281788
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221633

[Elliot Glaysher, 2013-09-05 00:49:30]

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:403:
button_size.height());
The whole left alignment case here does work, but isn't activated in this build.
I'll do that in a future patch where I start piping system configuration into
here. It also doesn't deal with the left side of the screen in the maximized
case yet.

[sky, 2013-09-05 15:54:32]

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:236:
minimize_button_->SetVisible(false);
Initially making hidden and then making visible right after this results in a
lot of unnecessary code running. Is it possible to have ConfigureButton control
the visibility entirely?

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:379: }
else NOTREACHED? Although I would likely just use a switch here.

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h (right):

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h:86: ALIGN_LEFT,
leading/trailing are a bit better since left/right are flipped when rtl.

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h:128: int
left_button_start_;
Same comment about left/right here.

[Elliot Glaysher, 2013-09-05 19:35:48]

PTAL. Also using switch statements now, leading/trailing instead of left/right,
etc.

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/23724019/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:236:
minimize_button_->SetVisible(false);
On 2013/09/05 15:54:32, sky wrote:
> Initially making hidden and then making visible right after this results in a
> lot of unnecessary code running. Is it possible to have ConfigureButton
control
> the visibility entirely?

While I can't have ConfigureButton() control this directly, I've replaced this
with the configuration code from my next patch which minimizes the calls to
SetVisible().

[sky, 2013-09-05 20:40:51]

LGTM

[commit-bot: I haz the power, 2013-09-06 00:44:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/23724019/24001

[commit-bot: I haz the power, 2013-09-06 07:47:58]

Change committed as 221633