Add device-independent rendering of ovals.

Add device-independent GPU rendering of ovals.

This permits GPU support for arbitrary matrices. The only exception is not all stroked ovals are supported, as thin ovals and fat strokes do not produce ellipses.

Committed: http://code.google.com/p/skia/source/detail?r=11075

[robertphillips, 2013-09-03 18:19:57]

lgtm + nits

https://codereview.chromium.org/23719004/diff/8001/include/gpu/GrOvalRenderer.h
File include/gpu/GrOvalRenderer.h (right):

https://codereview.chromium.org/23719004/diff/8001/include/gpu/GrOvalRenderer...
include/gpu/GrOvalRenderer.h:44: bool drawDIEllipse(GrDrawTarget* target, bool
useAA,
spaces

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:308: static GrEffectRef* Create(Mode mode) {
My OC side wants the kFill one first.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:312: 
Haha - same here.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:356: const SkString* attr0Name =
tab this line in a bit?

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:389: builder->fsCodeAppendf("\tgrad =
vec2(2.0*%s.w*duvdx.x + 2.0*%s.z*duvdx.y,\n"
line this up with prior line?

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:434: GrEffectRef*
DIEllipseEdgeEffect::TestCreate(SkMWCRandom* random,
spaces

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:718: bool GrOvalRenderer::drawDIEllipse(GrDrawTarget*
target,
spaces

[jvanverth1, 2013-09-04 13:11:24]

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:308: static GrEffectRef* Create(Mode mode) {
On 2013/09/03 18:19:57, robertphillips wrote:
> My OC side wants the kFill one first.

Done.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:312: 
On 2013/09/03 18:19:57, robertphillips wrote:
> Haha - same here.

Done.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:356: const SkString* attr0Name =
On 2013/09/03 18:19:57, robertphillips wrote:
> tab this line in a bit?

Done.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:389: builder->fsCodeAppendf("\tgrad =
vec2(2.0*%s.w*duvdx.x + 2.0*%s.z*duvdx.y,\n"
On 2013/09/03 18:19:57, robertphillips wrote:
> line this up with prior line?

Done.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:434: GrEffectRef*
DIEllipseEdgeEffect::TestCreate(SkMWCRandom* random,
On 2013/09/03 18:19:57, robertphillips wrote:
> spaces

Done.

https://codereview.chromium.org/23719004/diff/8001/src/gpu/GrOvalRenderer.cpp...
src/gpu/GrOvalRenderer.cpp:718: bool GrOvalRenderer::drawDIEllipse(GrDrawTarget*
target,
On 2013/09/03 18:19:57, robertphillips wrote:
> spaces

Done.

[commit-bot: I haz the power, 2013-09-04 13:12:27]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23719004/22003

[commit-bot: I haz the power, 2013-09-04 13:12:30]

Presubmit check for 23719004-22003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com')

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[jvanverth1, 2013-09-04 13:21:46]

Needs a LGTM from Brian since it's a public API...

[bsalomon, 2013-09-04 13:23:22]

On 2013/09/04 13:21:46, JimVV wrote:
> Needs a LGTM from Brian since it's a public API...

Hmm.. why is this a public API? Can we move the .h to src/gpu?

[jvanverth1, 2013-09-04 13:27:52]

On 2013/09/04 13:23:22, bsalomon wrote:
> On 2013/09/04 13:21:46, JimVV wrote:
> > Needs a LGTM from Brian since it's a public API...
> 
> Hmm.. why is this a public API? Can we move the .h to src/gpu?

That makes sense, but I'd rather do it as a separate change. What about
GrAARectRenderer.h?

[bsalomon, 2013-09-04 13:31:27]

On 2013/09/04 13:27:52, JimVV wrote:
> On 2013/09/04 13:23:22, bsalomon wrote:
> > On 2013/09/04 13:21:46, JimVV wrote:
> > > Needs a LGTM from Brian since it's a public API...
> > 
> > Hmm.. why is this a public API? Can we move the .h to src/gpu?
> 
> That makes sense, but I'd rather do it as a separate change. What about
> GrAARectRenderer.h?

It should be moved too. LGTM

[commit-bot: I haz the power, 2013-09-04 13:34:30]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23719004/22003

[commit-bot: I haz the power, 2013-09-04 14:14:52]

Change committed as 11075