Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23717053: Fix build/mac/edit_xibs.sh for gyp_main.py (Closed)

Created:
7 years, 3 months ago by Robert Sesek
Modified:
7 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build/mac/edit_xibs.sh for gyp_main.py R=thakis@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223411

Patch Set 1 #

Patch Set 2 : Remove python #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/mac/edit_xibs.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
7 years, 3 months ago (2013-09-16 20:55:05 UTC) #1
Nico
Can't you remove the "python" bit? Then this knows less over gyp internals. lgtm either ...
7 years, 3 months ago (2013-09-16 20:58:01 UTC) #2
Robert Sesek
On 2013/09/16 20:58:01, Nico wrote: > Can't you remove the "python" bit? Then this knows ...
7 years, 3 months ago (2013-09-16 21:00:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/23717053/7001
7 years, 3 months ago (2013-09-16 21:04:26 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 21:07:14 UTC) #5
Message was sent while issue was closed. 
Change committed as 223411

Powered by Google App Engine
This is Rietveld 408576698