Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23717045: Report trace event overhead stat with metadata (Closed)

Created:
7 years, 3 months ago by Xianzhu
Modified:
7 years, 3 months ago
Reviewers:
dsinclair, nduca
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Report trace event overhead stat with metadata BUG=trace-viewer:453 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222450

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -25 lines) Patch
M base/debug/trace_event_impl.cc View 3 chunks +5 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
7 years, 3 months ago (2013-09-10 17:21:41 UTC) #1
Xianzhu
This change actually makes the overhead stats disabled-by-default because for now trace-viewer doesn't know how ...
7 years, 3 months ago (2013-09-10 18:00:59 UTC) #2
Xianzhu
Patch Set 2 is LOG(INFO) only. Which one looks good to you?
7 years, 3 months ago (2013-09-10 18:11:19 UTC) #3
dsinclair
patch 1 lgtm. (Thanks for the clarifications)
7 years, 3 months ago (2013-09-10 20:24:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/23717045/2001
7 years, 3 months ago (2013-09-10 20:54:48 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 01:52:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 222450

Powered by Google App Engine
This is Rietveld 408576698