Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 23717043: Implement Custom Elements 'extends' option. (Closed)

Created:
7 years, 3 months ago by dominicc (has gone to gerrit)
Modified:
7 years, 3 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, webcomponents-bugzilla_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Visibility:
Public.

Description

Implement Custom Elements 'extends' option. This enables creating type extensions of elements without a differentiated prototype, like <section> (whose interface is HTMLElement) and elements without a distinct prototype, like <ins> and <del> (whose interface is HTMLModElement.) This relaxes a lot of prototype chain checks, in line with recent changes in the spec Working Draft. BUG=234509 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -121 lines) Patch
M LayoutTests/fast/dom/custom/document-register-basic.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-basic-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-namespace.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-namespace-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-null-constructor-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-throwing-constructor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-throwing-constructor-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-type-extensions.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/element-type.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/element-upgrade.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/custom/isolated-world.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-creation-api.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-innerHTML.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-paste.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/resources/document-register-fuzz.js View 3 chunks +9 lines, -4 lines 0 comments Download
A LayoutTests/fast/dom/custom/type-extensions.html View 1 chunk +67 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/type-extensions-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/custom/unresolved-pseudoclass.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.h View 3 chunks +1 line, -4 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 3 chunks +33 lines, -59 lines 0 comments Download
M Source/bindings/v8/V8PerContextData.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/dom/CustomElementException.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/CustomElementException.cpp View 1 chunk +6 lines, -10 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/core/scripts/make_names.pl View 4 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dominicc (has gone to gerrit)
PTAL
7 years, 3 months ago (2013-09-10 02:41:39 UTC) #1
Hajime Morrita
lgtm.
7 years, 3 months ago (2013-09-10 03:48:27 UTC) #2
dominicc (has gone to gerrit)
On 2013/09/10 03:48:27, morrita1 wrote: > lgtm. Thanks! <https://codereview.chromium.org/23702032/> has to go first so we ...
7 years, 3 months ago (2013-09-10 05:17:12 UTC) #3
dominicc (has gone to gerrit)
dglazkov: bindings/v8 left needing OWNERs, comments on everything welcome.
7 years, 3 months ago (2013-09-10 05:21:52 UTC) #4
dglazkov
lgtm.
7 years, 3 months ago (2013-09-10 15:29:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/23717043/1
7 years, 3 months ago (2013-09-10 22:57:40 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 01:01:12 UTC) #7
Message was sent while issue was closed.
Change committed as 157559

Powered by Google App Engine
This is Rietveld 408576698