Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23717041: Fix deadcode in an invalid string construction. (Closed)

Created:
7 years, 3 months ago by etienneb
Modified:
7 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix deadcode in an invalid string construction. This issue was found by a linter. R=yoz@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/extension_error.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
etienneb
PTAL.
7 years, 3 months ago (2013-09-09 23:31:03 UTC) #1
Yoyo Zhou
LGTM
7 years, 3 months ago (2013-09-09 23:31:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/23717041/1
7 years, 3 months ago (2013-09-09 23:35:38 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 02:05:21 UTC) #4
Message was sent while issue was closed. 
Change committed as 222182

Powered by Google App Engine
This is Rietveld 408576698