Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 23717040: Simple Cache: report age by (stream -> entry) (Closed)

Created:
7 years, 3 months ago by pasko
Modified:
7 years, 3 months ago
Reviewers:
clamy, Philippe, gavinp, pliard
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Simple Cache: report age by (stream -> entry) We have a histogram reporting 'entry age on Open of an existing entry' by looking at individual files on the filesystem. Change to report once for each entry. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M net/disk_cache/simple/simple_synchronous_entry.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pasko
7 years, 3 months ago (2013-09-09 15:32:54 UTC) #1
clamy
On 2013/09/09 15:32:54, pasko wrote: Thanks Egor! LGTM
7 years, 3 months ago (2013-09-09 15:36:30 UTC) #2
Philippe
lgtm, thanks Egor!
7 years, 3 months ago (2013-09-09 15:40:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@chromium.org/23717040/1
7 years, 3 months ago (2013-09-09 15:45:47 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 01:11:01 UTC) #5
Message was sent while issue was closed.
Change committed as 222166

Powered by Google App Engine
This is Rietveld 408576698