Issue 23717032: Disable "Choose file" button if "Favorites" checkbox is unchecked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23717032: Disable "Choose file" button if "Favorites" checkbox is unchecked. (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
Patrick Dubroy

CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable "Choose file" button if "Favorites" checkbox is unchecked. BUG=275343 TEST=open chrome, navigate to chrome://settings/importData, select the bookmarks option from the combobox, uncheck the "Favorites" checkbox, observe that the "Choose ..." button isn't enabled anymore, check it, it becomes enabled again. R=dubroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221923

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/options/import_data_overlay.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23717032/1

7 years, 3 months ago (2013-09-06 15:53:15 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76414

7 years, 3 months ago (2013-09-07 04:36:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23717032/1

7 years, 3 months ago (2013-09-07 12:36:07 UTC) #5

Message was sent while issue was closed.

Change committed as 221923

Expand Messages | Collapse Messages