Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 23716004: Fix cursor resources missing from browser for UI (fixes middle scroll) (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Fix cursor resources missing from browser for UI (fixes middle scroll) I don't see any reason why the .cur files are explicitly included and then (were) also included by the rather obliquely named ui_unscaled_resources. Assuming it's probably just cruft so nuke the .curs and re-include the .grd in the browser-side. All of the .cur that are in 'sources' are also in the .grd. R=jamesr@chromium.org BUG=283704, 237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/chrome_dll.gypi View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years, 3 months ago (2013-09-05 23:22:34 UTC) #1
jamesr
Cool, lgtm I think we probably should load cursors out of resources.pak but don't know ...
7 years, 3 months ago (2013-09-05 23:30:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23716004/1
7 years, 3 months ago (2013-09-05 23:34:56 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 07:47:29 UTC) #4
Message was sent while issue was closed.
Change committed as 221632

Powered by Google App Engine
This is Rietveld 408576698