Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 23715006: Translate: Don't use custom CSS and JavaScript loader on iOS (Closed)

Created:
7 years, 3 months ago by Takashi Toyoshima
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Translate: Don't use custom CSS and JavaScript loader on iOS Custom JavaScript loader doesn't work on iOS because an origin check fails outside v8 isolated world. Chrome should not overwrite these callbacks on iOS. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222254

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/translate/translate_script.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jeanfrancois
lgtm
7 years, 3 months ago (2013-09-10 08:43:10 UTC) #1
jeanfrancois
lgtm
7 years, 3 months ago (2013-09-10 08:43:11 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-10 08:49:00 UTC) #3
Takashi Toyoshima
+hajimehoshi
7 years, 3 months ago (2013-09-10 08:50:48 UTC) #4
droger
lgtm
7 years, 3 months ago (2013-09-10 09:02:10 UTC) #5
hajimehoshi
lgtm
7 years, 3 months ago (2013-09-10 09:02:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/23715006/3001
7 years, 3 months ago (2013-09-10 09:03:43 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167350
7 years, 3 months ago (2013-09-10 10:04:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/23715006/3001
7 years, 3 months ago (2013-09-10 11:05:15 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 12:33:25 UTC) #10
Message was sent while issue was closed.
Change committed as 222254

Powered by Google App Engine
This is Rietveld 408576698