Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 23714004: Implement GetResourceListInDirectoryByWapi. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Visibility:
Public.

Description

Implement GetResourceListInDirectoryByWapi. This CL introduces GetResourceListInDirectory by using WAPI even if we enables Drive API v2 for short term solution of preformance regression by API switching. BUG=283622 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220841

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
M chrome/browser/drive/drive_api_service.h View 1 chunk +6 lines, -0 lines 2 comments Download
M chrome/browser/drive/drive_api_service.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-09-02 07:53:26 UTC) #1
kinaba
https://codereview.chromium.org/23714004/diff/1/chrome/browser/drive/drive_api_service.h File chrome/browser/drive/drive_api_service.h (right): https://codereview.chromium.org/23714004/diff/1/chrome/browser/drive/drive_api_service.h#newcode190 chrome/browser/drive/drive_api_service.h:190: virtual google_apis::CancelCallback GetRemainingResourceList( For consistency, I'd rather like a ...
7 years, 3 months ago (2013-09-02 08:04:44 UTC) #2
hidehiko
Thank you for your review. PTAL? https://codereview.chromium.org/23714004/diff/1/chrome/browser/drive/drive_api_service.h File chrome/browser/drive/drive_api_service.h (right): https://codereview.chromium.org/23714004/diff/1/chrome/browser/drive/drive_api_service.h#newcode190 chrome/browser/drive/drive_api_service.h:190: virtual google_apis::CancelCallback GetRemainingResourceList( ...
7 years, 3 months ago (2013-09-02 08:52:04 UTC) #3
kinaba
On 2013/09/02 08:52:04, hidehiko wrote: > Thank you for your review. PTAL? > > https://codereview.chromium.org/23714004/diff/1/chrome/browser/drive/drive_api_service.h ...
7 years, 3 months ago (2013-09-02 09:23:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23714004/1
7 years, 3 months ago (2013-09-02 09:25:06 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 14:04:45 UTC) #6
Message was sent while issue was closed.
Change committed as 220841

Powered by Google App Engine
This is Rietveld 408576698