Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: Source/core/css/CSSGrammar.y.in

Issue 23710067: :-webkit-any pseudo with escaped '(' should not crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed workaround code for :not() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/pseudo-escaped-parenthesis-expected.txt ('k') | Source/core/css/CSSParserValues.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSGrammar.y.in
diff --git a/Source/core/css/CSSGrammar.y.in b/Source/core/css/CSSGrammar.y.in
index d437fb6d2cb4ff2522e62b038183b6f312daad29..da016a2f6ee9af87d96a26d1fa685259f29dea91 100644
--- a/Source/core/css/CSSGrammar.y.in
+++ b/Source/core/css/CSSGrammar.y.in
@@ -1382,6 +1382,8 @@ ident_or_string:
pseudo_page:
':' IDENT {
+ if ($2.isFunction())
+ YYERROR;
$$ = parser->createFloatingSelector();
$$->setMatch(CSSSelector::PagePseudoClass);
parser->tokenToLowerCase($2);
@@ -1393,6 +1395,8 @@ pseudo_page:
pseudo:
':' error_location IDENT {
+ if ($3.isFunction())
+ YYERROR;
$$ = parser->createFloatingSelector();
$$->setMatch(CSSSelector::PseudoClass);
parser->tokenToLowerCase($3);
@@ -1404,6 +1408,8 @@ pseudo:
}
}
| ':' ':' error_location IDENT {
+ if ($4.isFunction())
+ YYERROR;
$$ = parser->createFloatingSelector();
$$->setMatch(CSSSelector::PseudoElement);
parser->tokenToLowerCase($4);
« no previous file with comments | « LayoutTests/fast/css/pseudo-escaped-parenthesis-expected.txt ('k') | Source/core/css/CSSParserValues.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698