Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Issue 23710029: Use an X event loop in the GPU process on Linux. (Closed)

Created:
7 years, 3 months ago by ccameron
Modified:
7 years, 3 months ago
CC:
chromium-reviews, sadrul, grt+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Use an X event loop in the GPU process on Linux. In future patches, X windows will be created in the GPU process, and events sent to these windows will need to be forwarded to their parent windows. Linux uses GTK as the default UI event loop type, but GTK is not in the GPU process, so the X11 event loop type is used instead. Update package dependencies. BUG=145600 TBR=thakis, piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M base/message_loop/message_loop.h View 5 chunks +19 lines, -1 line 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/message_loop/message_pump_x11.h View 1 chunk +1 line, -3 lines 0 comments Download
M base/message_loop/message_pump_x11.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ccameron
This is take 2, with the dependencies that I missed in http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/44216/steps/compile/logs/stdio Does this look ...
7 years, 3 months ago (2013-09-11 18:56:37 UTC) #1
Michael Moss
lgtm
7 years, 3 months ago (2013-09-11 19:35:24 UTC) #2
Elliot Glaysher
lgtm On Wed, Sep 11, 2013 at 12:35 PM, <mmoss@chromium.org> wrote: > lgtm > > ...
7 years, 3 months ago (2013-09-11 19:45:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/23710029/1
7 years, 3 months ago (2013-09-11 20:10:52 UTC) #4
ccameron
Thanks!!
7 years, 3 months ago (2013-09-11 20:12:28 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 01:12:10 UTC) #6
Message was sent while issue was closed.
Change committed as 222689

Powered by Google App Engine
This is Rietveld 408576698