Issue 23710017: Guest mode login changes.

Issue 23710017: Guest mode login changes. (Closed)

Created:
7 years, 3 months ago by achuithb

Modified:
7 years, 3 months ago

Reviewers:
Tim Song

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Guest mode login changes. oobe timeout error is no longer accurate, so update it. Do not copy the chrome_login_ext if it's not going to be used. BUG=None Test=login_CryptohomeTelemetry, login_CryptohomeIncognitoTelemetry, and telemetry unittests for cros (regular + guest) NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221742

Patch Set 1 #

Patch Set 2 : one more fix #

Total comments: 2

Patch Set 3 : tengs feedback #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -28 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py	View	1 2	6 chunks	+38 lines, -28 lines	2 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23710017/1

7 years, 3 months ago (2013-09-05 22:33:23 UTC) #4

achuithb

Tim, I've made one more change. Both the Gaia signin screen (where you see the ...

7 years, 3 months ago (2013-09-05 23:12:23 UTC) #5

Tim Song

lgtm https://codereview.chromium.org/23710017/diff/6001/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/23710017/diff/6001/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode339 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:339: def _WaitForAccountPicker(self): Let's update the name to _WaitForSigninScreen.

7 years, 3 months ago (2013-09-06 00:40:45 UTC) #6

achuithb

ty! https://codereview.chromium.org/23710017/diff/6001/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/23710017/diff/6001/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode339 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:339: def _WaitForAccountPicker(self): On 2013/09/06 00:40:45, Tim Song wrote: ...

7 years, 3 months ago (2013-09-06 18:35:39 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23710017/6002

7 years, 3 months ago (2013-09-06 18:36:01 UTC) #8

Tim Song

https://codereview.chromium.org/23710017/diff/6002/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/23710017/diff/6002/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode339 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:339: def _WaitForSigininScreen(self): Typo here.

7 years, 3 months ago (2013-09-06 18:42:53 UTC) #10

achuithb

7 years, 3 months ago (2013-09-06 18:51:34 UTC) #11

Message was sent while issue was closed.

https://codereview.chromium.org/23710017/diff/6002/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/23710017/diff/6002/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:339: def
_WaitForSigininScreen(self):
On 2013/09/06 18:42:53, Tim Song wrote:
> Typo here.

Ah sorry: https://codereview.chromium.org/23688006/

Expand Messages | Collapse Messages