Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 23709010: Replace OnIPAddressChanged with OnNetworkChanged. (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Replace OnIPAddressChanged with OnNetworkChanged. Delay discovery service restart by 10 sec. Added IPs VLOG. TBR=noamsml BUG=284673 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223322

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -18 lines) Patch
M chrome/browser/local_discovery/service_discovery_host_client.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_host_client.cc View 4 chunks +45 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23709010/5001
7 years, 3 months ago (2013-09-16 07:34:25 UTC) #1
commit-bot: I haz the power
Change committed as 223322
7 years, 3 months ago (2013-09-16 09:57:15 UTC) #2
Noam Samuel
7 years, 3 months ago (2013-09-16 17:46:04 UTC) #3
Message was sent while issue was closed.
On 2013/09/16 09:57:15, I haz the power (commit-bot) wrote:
> Change committed as 223322

lgtm

Powered by Google App Engine
This is Rietveld 408576698