Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 23708049: Cap allocation for ImmutableStylePropertySet. (Closed)

Created:
7 years, 3 months ago by rune
Modified:
7 years, 3 months ago
Reviewers:
eseidel, inferno
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cap allocation for ImmutableStylePropertySet. The m_arraySize will be capped to MaxArraySize, so it is unnecessary to allocate room for more than MaxArraySize properties. Leftover from https://codereview.chromium.org/22917005/ BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158093

Patch Set 1 #

Patch Set 2 : Use ASSERT instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/css/StylePropertySet.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
7 years, 3 months ago (2013-09-19 09:29:55 UTC) #1
eseidel
Should this be an ASSERT? Will callers assume it is count size and try to ...
7 years, 3 months ago (2013-09-19 15:07:16 UTC) #2
rune
On 2013/09/19 15:07:16, eseidel wrote: > Should this be an ASSERT? Will callers assume it ...
7 years, 3 months ago (2013-09-19 19:47:27 UTC) #3
rune
On 2013/09/19 19:47:27, rune wrote: > On 2013/09/19 15:07:16, eseidel wrote: > > Should this ...
7 years, 3 months ago (2013-09-19 23:48:33 UTC) #4
eseidel
lgtm OK.
7 years, 3 months ago (2013-09-19 23:57:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23708049/5001
7 years, 3 months ago (2013-09-20 07:18:41 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 08:55:10 UTC) #7
Message was sent while issue was closed.
Change committed as 158093

Powered by Google App Engine
This is Rietveld 408576698