Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 23708045: [Activity Log] Disable all the activity log end to end tests on win. (Closed)

Created:
7 years, 3 months ago by karenlees
Modified:
7 years, 2 months ago
Reviewers:
felt, Bei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Visibility:
Public.

Description

[Activity Log] Disable all the activity log end to end tests on win. Disable all activity log end to end tests on windows. BUG=245594 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223532

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix missing # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
karenlees
7 years, 3 months ago (2013-09-17 03:50:58 UTC) #1
felt
lgtm, win going back off? pls add bug=245594 to description
7 years, 3 months ago (2013-09-17 03:54:12 UTC) #2
Bei Zhang
https://codereview.chromium.org/23708045/diff/1/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc File chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc (right): https://codereview.chromium.org/23708045/diff/1/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc#newcode37 chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc:37: else #else
7 years, 3 months ago (2013-09-17 03:58:07 UTC) #3
karenlees
On 2013/09/17 03:58:07, Bei Zhang wrote: > https://codereview.chromium.org/23708045/diff/1/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc > File > chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc > (right): > ...
7 years, 3 months ago (2013-09-17 04:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/karenlees@chromium.org/23708045/7001
7 years, 3 months ago (2013-09-17 04:03:19 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 04:04:48 UTC) #6
Message was sent while issue was closed.
Change committed as 223532

Powered by Google App Engine
This is Rietveld 408576698