Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 23708033: android: Download ARMv7 image for the emulator. (Closed)

Created:
7 years, 3 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android: Download ARMv7 image for the emulator. Follow-up to r222121: GetSDK() used to download an additional copy of the Android SDK that came with an ARM image. The copy we currently use in third_party/android_tools/sdk does not come with the ARM image. Restore the lost functionality while still avoiding downloading the complete SDK by grabbing only the ARM images from a Google URL. R=mariakhomenko@chromium.org,peter@chromium.org,bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223003

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch v2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M build/android/install_emulator_deps.py View 1 5 chunks +37 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Raphael Kubo da Costa (rakuco)
This is related to https://codereview.chromium.org/23513022/ (especially comments #13-#15). Maria, could you take a look and ...
7 years, 3 months ago (2013-09-12 09:42:02 UTC) #1
Raphael Kubo da Costa (rakuco)
As I mentioned in the other CL, both this and https://codereview.chromium.org/23513022/ are based on trunk, ...
7 years, 3 months ago (2013-09-12 09:42:55 UTC) #2
Maria
lgtm
7 years, 3 months ago (2013-09-12 17:28:15 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-12 17:40:56 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/23708033/diff/1/build/android/install_emulator_deps.py File build/android/install_emulator_deps.py (right): https://codereview.chromium.org/23708033/diff/1/build/android/install_emulator_deps.py#newcode107 build/android/install_emulator_deps.py:107: raise This is suspect. You're not catching any exception ...
7 years, 3 months ago (2013-09-12 17:44:43 UTC) #5
Raphael Kubo da Costa (rakuco)
Fixed in patch v2.
7 years, 3 months ago (2013-09-12 17:54:18 UTC) #6
Paweł Hajdan Jr.
LGTM
7 years, 3 months ago (2013-09-12 17:55:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/23708033/9001
7 years, 3 months ago (2013-09-12 18:01:09 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=78380
7 years, 3 months ago (2013-09-13 03:22:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/23708033/9001
7 years, 3 months ago (2013-09-13 08:16:26 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 08:18:40 UTC) #11
Message was sent while issue was closed.
Change committed as 223003

Powered by Google App Engine
This is Rietveld 408576698