Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: chrome/browser/apps/app_browsertest.cc

Issue 23708018: Modified comment in PlatformAppBrowserTest.WindowDotPrintWorks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/launcher.h" 5 #include "apps/launcher.h"
6 #include "apps/native_app_window.h" 6 #include "apps/native_app_window.h"
7 #include "apps/shell_window.h" 7 #include "apps/shell_window.h"
8 #include "apps/shell_window_registry.h" 8 #include "apps/shell_window_registry.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 GetRenderWidgetHostView()->HasFocus()); 1037 GetRenderWidgetHostView()->HasFocus());
1038 } 1038 }
1039 1039
1040 // The next test will only run automatically with Chrome branded builds because 1040 // The next test will only run automatically with Chrome branded builds because
1041 // it requires the PDF preview plug-in. To run this test manually for Chromium 1041 // it requires the PDF preview plug-in. To run this test manually for Chromium
1042 // builds (non-Chrome branded) in a development environment: 1042 // builds (non-Chrome branded) in a development environment:
1043 // 1043 //
1044 // 1) Remove "MAYBE_" in the first line of the test definition 1044 // 1) Remove "MAYBE_" in the first line of the test definition
1045 // 2) Build Chromium browser_tests 1045 // 2) Build Chromium browser_tests
1046 // 3) Make a copy of the PDF plug-in from a recent version of Chrome (Canary 1046 // 3) Make a copy of the PDF plug-in from a recent version of Chrome (Canary
1047 // or recent development build) to your Chromium build. On Linux and Chrome 1047 // or a recent development build) to your Chromium build:
1048 // OS, this just involves copying /opt/google.chrome/libpdf.so to 1048 // - On Linux and Chrome OS, copy /opt/google.chrome/libpdf.so to
1049 // <path-to-your-src>/out/Debug. 1049 // <path-to-your-src>/out/Debug
1050 // - On OS X, copy PDF.plugin from
1051 // <recent-chrome-app-folder>/*/*/*/*/"Internet Plug-Ins" to
1052 // <path-to-your-src>/out/Debug/Chromium.app/*/*/*/*/"Internet Plug-Ins"
1050 // 4) Run browser_tests with the --enable-print-preview flag 1053 // 4) Run browser_tests with the --enable-print-preview flag
1051 1054
1052 #if !defined(GOOGLE_CHROME_BUILD) 1055 #if !defined(GOOGLE_CHROME_BUILD)
1053 #define MAYBE_WindowDotPrintWorks DISABLED_WindowDotPrintWorks 1056 #define MAYBE_WindowDotPrintWorks DISABLED_WindowDotPrintWorks
1054 #else 1057 #else
1055 #define MAYBE_WindowDotPrintWorks WindowDotPrintWorks 1058 #define MAYBE_WindowDotPrintWorks WindowDotPrintWorks
1056 #endif 1059 #endif
1057 1060
1058 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WindowDotPrintWorks) { 1061 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WindowDotPrintWorks) {
1059 PrintPreviewUI::SetAutoCancelForTesting(true); 1062 PrintPreviewUI::SetAutoCancelForTesting(true);
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
1117 1120
1118 while (!ContainsKey(opener_app_ids_, file_manager->id())) { 1121 while (!ContainsKey(opener_app_ids_, file_manager->id())) {
1119 content::RunAllPendingInMessageLoop(); 1122 content::RunAllPendingInMessageLoop();
1120 } 1123 }
1121 } 1124 }
1122 1125
1123 #endif // defined(OS_CHROMEOS) 1126 #endif // defined(OS_CHROMEOS)
1124 1127
1125 1128
1126 } // namespace extensions 1129 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698