Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 23708010: Address deferred comments from https://codereview.chromium.org/23464005/ (Closed)

Created:
7 years, 3 months ago by ddorwin
Modified:
7 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Address deferred comments from review of r220664. BUG=224793 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220702

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix indent #

Patch Set 3 : rebase only #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M content/renderer/media/crypto/key_systems.cc View 1 2 3 10 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ddorwin
This CL addresses deferred comments in https://codereview.chromium.org/23464005/ along with TODOs added in it.
7 years, 3 months ago (2013-08-29 23:14:07 UTC) #1
xhwang
lgtm % one tiny nit, thanks! https://codereview.chromium.org/23708010/diff/1/content/renderer/media/crypto/key_systems.cc File content/renderer/media/crypto/key_systems.cc (right): https://codereview.chromium.org/23708010/diff/1/content/renderer/media/crypto/key_systems.cc#newcode146 content/renderer/media/crypto/key_systems.cc:146: CodecSet codecs(mime_type_codecs.begin(), mime_type_codecs.end()); ...
7 years, 3 months ago (2013-08-29 23:16:19 UTC) #2
ddorwin
Updated description too. https://codereview.chromium.org/23708010/diff/1/content/renderer/media/crypto/key_systems.cc File content/renderer/media/crypto/key_systems.cc (right): https://codereview.chromium.org/23708010/diff/1/content/renderer/media/crypto/key_systems.cc#newcode146 content/renderer/media/crypto/key_systems.cc:146: CodecSet codecs(mime_type_codecs.begin(), mime_type_codecs.end()); On 2013/08/29 23:16:19, ...
7 years, 3 months ago (2013-08-30 21:47:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/23708010/11001
7 years, 3 months ago (2013-08-30 21:49:24 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-31 00:01:35 UTC) #5
Message was sent while issue was closed.
Change committed as 220702

Powered by Google App Engine
This is Rietveld 408576698