Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 23708009: Add ShouldSkip variant that can read a --match flag directly. (Closed)

Created:
7 years, 3 months ago by mtklein
Modified:
7 years, 3 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add ShouldSkip variant that can read a --match flag directly. Just seemed like we were going through lots of hoops for this common case. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11034

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M experimental/SkiaExamples/SkExample.h View 1 chunk +0 lines, -1 line 0 comments Download
M experimental/SkiaExamples/SkExample.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M gm/gmmain.cpp View 4 chunks +1 line, -10 lines 0 comments Download
M tests/skia_test.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M tools/flags/SkCommandLineFlags.h View 2 chunks +10 lines, -9 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
7 years, 3 months ago (2013-08-29 22:19:34 UTC) #1
scroggo
On 2013/08/29 22:19:34, mtklein wrote: Can you try reuploading? Everything just shows "error: old chunk ...
7 years, 3 months ago (2013-08-30 12:40:23 UTC) #2
mtklein
On 2013/08/30 12:40:23, scroggo wrote: > On 2013/08/29 22:19:34, mtklein wrote: > > Can you ...
7 years, 3 months ago (2013-08-30 13:25:11 UTC) #3
scroggo
lgtm
7 years, 3 months ago (2013-08-30 13:27:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/23708009/16001
7 years, 3 months ago (2013-08-30 13:29:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/23708009/16001
7 years, 3 months ago (2013-08-30 13:30:24 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 15:52:54 UTC) #7
Message was sent while issue was closed.
Change committed as 11034

Powered by Google App Engine
This is Rietveld 408576698