Issue 23707007: Handlify JSProxy::Fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23707007: Handlify JSProxy::Fix (Closed)

Created:
7 years, 3 months ago by Toon Verwaest

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify JSProxy::Fix R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16452

Patch Set 2 : Addressed comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -17 lines)			Patch
M	src/objects.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1	2 chunks	+16 lines, -13 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one nit and one comment. https://codereview.chromium.org/23707007/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23707007/diff/1/src/objects.cc#newcode3655 src/objects.cc:3655: void JSProxy::Fix(Handle<JSProxy> ...

7 years, 3 months ago (2013-08-30 10:56:31 UTC) #2

Toon Verwaest

7 years, 3 months ago (2013-08-30 12:52:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16452 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23707007: Handlify JSProxy::Fix (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages