Port messages sent by WebIDBFactoryImpl to Mojo.

third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
  *     documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "modules/indexeddb/WebIDBDatabaseCallbacksImpl.h"
 
 #include "core/dom/DOMException.h"
 #include "wtf/PtrUtil.h"
+#include "wtf/ThreadSpecific.h"
 #include <memory>
 
 namespace blink {
 
+// This thread-specific list keeps track of instances of
+// WebIDBDatabaseCallbacksImpl created by each thread. If a thread exits
+// before they are destroyed then they would otherwise be leaked because the IO
+// thread can no longer post a task to the thread on which they were created.
+using CallbacksList = std::vector<std::unique_ptr<WebIDBDatabaseCallbacksImpl>>;
+static ThreadSpecific<CallbacksList>& outstandingCallbacks() {
+  DEFINE_THREAD_SAFE_STATIC_LOCAL(ThreadSpecific<CallbacksList>, callbacks,
+                                  new ThreadSpecific<CallbacksList>);
+  return callbacks;
+}
+
 // static
 std::unique_ptr<WebIDBDatabaseCallbacksImpl>
 WebIDBDatabaseCallbacksImpl::create(IDBDatabaseCallbacks* callbacks) {
   return wrapUnique(new WebIDBDatabaseCallbacksImpl(callbacks));
 }
 
 WebIDBDatabaseCallbacksImpl::WebIDBDatabaseCallbacksImpl(
     IDBDatabaseCallbacks* callbacks)
-    : m_callbacks(callbacks) {}
+    : m_callbacks(callbacks) {
+  outstandingCallbacks()->push_back(wrapUnique(this));
+}
 
-WebIDBDatabaseCallbacksImpl::~WebIDBDatabaseCallbacksImpl() {}
+WebIDBDatabaseCallbacksImpl::~WebIDBDatabaseCallbacksImpl() {

[haraken, 2016/10/18 19:01:29]

Maybe we want to share the code with WebIDBCallbacksImpl.

[Reilly Grant (use Gerrit), 2016/10/19 00:36:51]

I've moved this logic into IndexedDBDispatcher where it is a little less
verbose.

+  if (m_callbacks)
+    m_callbacks->webCallbacksDestroyed();
+
+  CallbacksList& callbacks = *outstandingCallbacks();
+  auto it = std::find_if(
+      callbacks.begin(), callbacks.end(),
+      [this](const std::unique_ptr<WebIDBDatabaseCallbacksImpl>& element) {
+        return element.get() == this;
+      });
+  if (it != callbacks.end()) {
+    it->release();
+    callbacks.erase(it);
+  }
+}
 
 void WebIDBDatabaseCallbacksImpl::onForcedClose() {
-  m_callbacks->onForcedClose();
+  if (m_callbacks)
+    m_callbacks->onForcedClose();
 }
 
 void WebIDBDatabaseCallbacksImpl::onVersionChange(long long oldVersion,
                                                   long long newVersion) {
-  m_callbacks->onVersionChange(oldVersion, newVersion);
+  if (m_callbacks)
+    m_callbacks->onVersionChange(oldVersion, newVersion);
 }
 
 void WebIDBDatabaseCallbacksImpl::onAbort(long long transactionId,
                                           const WebIDBDatabaseError& error) {
-  m_callbacks->onAbort(transactionId,
-                       DOMException::create(error.code(), error.message()));
+  if (m_callbacks) {
+    m_callbacks->onAbort(transactionId,
+                         DOMException::create(error.code(), error.message()));
+  }
 }
 
 void WebIDBDatabaseCallbacksImpl::onComplete(long long transactionId) {
-  m_callbacks->onComplete(transactionId);
+  if (m_callbacks)
+    m_callbacks->onComplete(transactionId);
+}
+
+void WebIDBDatabaseCallbacksImpl::detach() {
+  m_callbacks.clear();
 }
 
 }  // namespace blink