Adding decorations(icons) in right order to omnibox

This CL changes the order in which icons are added to the omnibox to reverse order as it is done in aura. 

BUG=290941
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223607

[npentrel, 2013-09-13 15:09:44]

Hi Ilya, 

Please have a look at this CL. I mentioned this in a CL I sent out earlier. You
can find more information in the bug description.

Thanks,
Naomi

[Ilya Sherman, 2013-09-14 04:01:32]

LGTM % nit, thanks.

https://codereview.chromium.org/23704009/diff/1/chrome/browser/ui/cocoa/locat...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/23704009/diff/1/chrome/browser/ui/cocoa/locat...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:664: // Reverse
iterating through |content_setting_decoration_| as in aura
nit: "Iterate through |content_setting_decorations_| in reverse order so that
the order in which the decorations are drawn matches the Views code."

https://codereview.chromium.org/23704009/diff/1/chrome/browser/ui/cocoa/locat...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:665: for (int i =
content_setting_decorations_.size()-1; i >= 0; --i) {
nit: Please use rbegin() and rend() for iterating through the vector.  Or, if
you really prefer to keep the index variable, add spaces around the minus sign
in "content_setting_decorations_.size()-1".

[npentrel, 2013-09-17 11:13:21]

https://codereview.chromium.org/23704009/diff/1/chrome/browser/ui/cocoa/locat...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/23704009/diff/1/chrome/browser/ui/cocoa/locat...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:664: // Reverse
iterating through |content_setting_decoration_| as in aura
On 2013/09/14 04:01:32, Ilya Sherman wrote:
> nit: "Iterate through |content_setting_decorations_| in reverse order so that
> the order in which the decorations are drawn matches the Views code."

Done.

https://codereview.chromium.org/23704009/diff/1/chrome/browser/ui/cocoa/locat...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:665: for (int i =
content_setting_decorations_.size()-1; i >= 0; --i) {
On 2013/09/14 04:01:32, Ilya Sherman wrote:
> nit: Please use rbegin() and rend() for iterating through the vector.  Or, if
> you really prefer to keep the index variable, add spaces around the minus sign
> in "content_setting_decorations_.size()-1".

Done.

[commit-bot: I haz the power, 2013-09-17 11:14:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/npentrel@chromium.org/23704009/8001

[commit-bot: I haz the power, 2013-09-17 13:54:05]

Change committed as 223607