Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 23704006: Mapped es-419 to es-MX for iOS. (Closed)

Created:
7 years, 3 months ago by jeanfrancois
Modified:
7 years, 3 months ago
Reviewers:
stuartmorgan, Jói
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Mapped es-419 to es-MX for iOS. Used a script that: 1/ searches for all files with a "grd" extension that contain "<!-- iOS uses pt for pt-BR -->". 2/ in those files, replaces all occurrences of '.*<output filename="(.*)_es-419.pak" type="(.*)" lang="es-419.*' with: <if expr="is_ios"> <!-- iOS uses es-MX for es-419 --> <output filename="%s_es-MX.pak" type="%s" lang="es-419" /> </if> <if expr="not is_ios"> <output filename="%s_es-419.pak" type="%s" lang="es-419" /> </if> BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221038

Patch Set 1 #

Patch Set 2 : Fixed double quotes. #

Patch Set 3 : es-419 => es-MX #

Patch Set 4 : Adding es-MX to the locales list. #

Patch Set 5 : Added missing quote. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -12 lines) Patch
M build/common.gypi View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M chrome/app/resources/locale_settings.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M components/component_strings.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M ui/base/strings/app_locale_settings.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M ui/base/strings/ui_strings.grd View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jeanfrancois
ptal
7 years, 3 months ago (2013-09-03 10:14:51 UTC) #1
stuartmorgan
lgtm
7 years, 3 months ago (2013-09-03 14:35:54 UTC) #2
stuartmorgan
Oh, we'll also need to update the ios locales list in common.gypi; that should be ...
7 years, 3 months ago (2013-09-03 14:39:58 UTC) #3
jeanfrancois
+joi for OWNERS
7 years, 3 months ago (2013-09-03 15:06:45 UTC) #4
Jói
LGTM
7 years, 3 months ago (2013-09-03 15:13:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeanfrancoisg@chromium.org/23704006/9001
7 years, 3 months ago (2013-09-03 15:14:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=73438
7 years, 3 months ago (2013-09-03 15:30:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeanfrancoisg@chromium.org/23704006/32001
7 years, 3 months ago (2013-09-03 15:40:46 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 22:16:42 UTC) #9
Message was sent while issue was closed.
Change committed as 221038

Powered by Google App Engine
This is Rietveld 408576698