Issue 23703007: Fix SourceBufferStream::Remove() for buffers before the current play position.

Issue 23703007: Fix SourceBufferStream::Remove() for buffers before the current play position. (Closed)

Created:
7 years, 3 months ago by acolwell GONE FROM CHROMIUM

Modified:
7 years, 3 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix SourceBufferStream::Remove() for buffers before the current play position. BUG=286442 TEST=SourceBufferStreamTest.Remove_BeforeCurrentPosition Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221896

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 2

Patch Set 3 : Address CR comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -5 lines)			Patch
	M	media/filters/source_buffer_stream.cc	View		5 chunks	+18 lines, -4 lines	0 comments	Download
	M	media/filters/source_buffer_stream_unittest.cc	View	1 2	2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

lgtm https://codereview.chromium.org/23703007/diff/6001/media/filters/source_buffer_stream_unittest.cc File media/filters/source_buffer_stream_unittest.cc (right): https://codereview.chromium.org/23703007/diff/6001/media/filters/source_buffer_stream_unittest.cc#newcode2967 media/filters/source_buffer_stream_unittest.cc:2967: // Test behavior when buffers in the selected ...

7 years, 3 months ago (2013-09-06 20:50:21 UTC) #2

acolwell GONE FROM CHROMIUM

https://codereview.chromium.org/23703007/diff/6001/media/filters/source_buffer_stream_unittest.cc File media/filters/source_buffer_stream_unittest.cc (right): https://codereview.chromium.org/23703007/diff/6001/media/filters/source_buffer_stream_unittest.cc#newcode2967 media/filters/source_buffer_stream_unittest.cc:2967: // Test behavior when buffers in the selected range ...

7 years, 3 months ago (2013-09-06 20:52:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/23703007/14001

7 years, 3 months ago (2013-09-06 20:52:48 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 3 months ago (2013-09-06 20:57:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/23703007/14001

7 years, 3 months ago (2013-09-06 20:59:08 UTC) #6

Message was sent while issue was closed.

Change committed as 221896

Expand Messages | Collapse Messages