Issue 23702045: [android] Test scripts log the list of files changed on the device when pushing dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23702045: [android] Test scripts log the list of files changed on the device when pushing dependencies. (Closed)

Created:
7 years, 3 months ago by craigdh

Modified:
7 years, 3 months ago

Reviewers:
frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Test scripts log the list of files changed on the device when pushing dependencies. BUG=288964 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223675

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/pylib/android_commands.py	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm https://codereview.chromium.org/23702045/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/23702045/diff/1/build/android/pylib/android_commands.py#newcode866 build/android/pylib/android_commands.py:866: logging.info([os.path.relpath(f[0], host_path) for f in changed_files]) Why relative ...

7 years, 3 months ago (2013-09-17 18:16:25 UTC) #2

craigdh

> Why relative path? Because we already log the base directory that's being pushed and ...

7 years, 3 months ago (2013-09-17 18:48:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/23702045/1

7 years, 3 months ago (2013-09-17 20:27:04 UTC) #4

Message was sent while issue was closed.

Change committed as 223675

Expand Messages | Collapse Messages