Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 23702040: Send synchronous loads through the cache. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/xml/XSLTProcessorLibxslt.cpp ('k') | Source/web/ApplicationCacheHost.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2000 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 5 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2008 Holger Hans Peter Freyther 7 * Copyright (C) 2008 Holger Hans Peter Freyther
8 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
11 * modify it under the terms of the GNU Library General Public 11 * modify it under the terms of the GNU Library General Public
12 * License as published by the Free Software Foundation; either 12 * License as published by the Free Software Foundation; either
13 * version 2 of the License, or (at your option) any later version. 13 * version 2 of the License, or (at your option) any later version.
14 * 14 *
15 * This library is distributed in the hope that it will be useful, 15 * This library is distributed in the hope that it will be useful,
16 * but WITHOUT ANY WARRANTY; without even the implied warranty of 16 * but WITHOUT ANY WARRANTY; without even the implied warranty of
17 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 17 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18 * Library General Public License for more details. 18 * Library General Public License for more details.
19 * 19 *
20 * You should have received a copy of the GNU Library General Public License 20 * You should have received a copy of the GNU Library General Public License
21 * along with this library; see the file COPYING.LIB. If not, write to 21 * along with this library; see the file COPYING.LIB. If not, write to
22 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 22 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
23 * Boston, MA 02110-1301, USA. 23 * Boston, MA 02110-1301, USA.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/xml/parser/XMLDocumentParser.h" 27 #include "core/xml/parser/XMLDocumentParser.h"
28 28
29 #include "FetchInitiatorTypeNames.h"
29 #include "HTMLNames.h" 30 #include "HTMLNames.h"
30 #include "XMLNSNames.h" 31 #include "XMLNSNames.h"
31 #include "bindings/v8/ExceptionState.h" 32 #include "bindings/v8/ExceptionState.h"
32 #include "bindings/v8/ExceptionStatePlaceholder.h" 33 #include "bindings/v8/ExceptionStatePlaceholder.h"
33 #include "bindings/v8/ScriptController.h" 34 #include "bindings/v8/ScriptController.h"
34 #include "bindings/v8/ScriptSourceCode.h" 35 #include "bindings/v8/ScriptSourceCode.h"
35 #include "core/dom/CDATASection.h" 36 #include "core/dom/CDATASection.h"
36 #include "core/dom/Comment.h" 37 #include "core/dom/Comment.h"
37 #include "core/dom/Document.h" 38 #include "core/dom/Document.h"
38 #include "core/dom/DocumentFragment.h" 39 #include "core/dom/DocumentFragment.h"
39 #include "core/dom/DocumentType.h" 40 #include "core/dom/DocumentType.h"
40 #include "core/dom/ProcessingInstruction.h" 41 #include "core/dom/ProcessingInstruction.h"
41 #include "core/dom/ScriptLoader.h" 42 #include "core/dom/ScriptLoader.h"
42 #include "core/dom/TransformSource.h" 43 #include "core/dom/TransformSource.h"
43 #include "core/fetch/ResourceFetcher.h" 44 #include "core/fetch/ResourceFetcher.h"
44 #include "core/fetch/ScriptResource.h" 45 #include "core/fetch/ScriptResource.h"
45 #include "core/fetch/TextResourceDecoder.h" 46 #include "core/fetch/TextResourceDecoder.h"
46 #include "core/html/HTMLHtmlElement.h" 47 #include "core/html/HTMLHtmlElement.h"
47 #include "core/html/HTMLTemplateElement.h" 48 #include "core/html/HTMLTemplateElement.h"
48 #include "core/html/parser/HTMLEntityParser.h" 49 #include "core/html/parser/HTMLEntityParser.h"
49 #include "core/loader/FrameLoader.h" 50 #include "core/loader/FrameLoader.h"
50 #include "core/loader/ImageLoader.h" 51 #include "core/loader/ImageLoader.h"
51 #include "core/page/Frame.h" 52 #include "core/page/Frame.h"
52 #include "core/page/UseCounter.h" 53 #include "core/page/UseCounter.h"
54 #include "core/platform/SharedBuffer.h"
53 #include "core/platform/network/ResourceError.h" 55 #include "core/platform/network/ResourceError.h"
54 #include "core/platform/network/ResourceRequest.h" 56 #include "core/platform/network/ResourceRequest.h"
55 #include "core/platform/network/ResourceResponse.h" 57 #include "core/platform/network/ResourceResponse.h"
56 #include "core/xml/XMLErrors.h" 58 #include "core/xml/XMLErrors.h"
57 #include "core/xml/XMLTreeViewer.h" 59 #include "core/xml/XMLTreeViewer.h"
58 #include "core/xml/parser/XMLDocumentParserScope.h" 60 #include "core/xml/parser/XMLDocumentParserScope.h"
59 #include "core/xml/parser/XMLParserInput.h" 61 #include "core/xml/parser/XMLParserInput.h"
60 #include "weborigin/SecurityOrigin.h" 62 #include "weborigin/SecurityOrigin.h"
61 #include "wtf/StringExtras.h" 63 #include "wtf/StringExtras.h"
62 #include "wtf/TemporaryChange.h" 64 #include "wtf/TemporaryChange.h"
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 static void* openFunc(const char* uri) 632 static void* openFunc(const char* uri)
631 { 633 {
632 ASSERT(XMLDocumentParserScope::currentFetcher); 634 ASSERT(XMLDocumentParserScope::currentFetcher);
633 ASSERT(currentThread() == libxmlLoaderThread); 635 ASSERT(currentThread() == libxmlLoaderThread);
634 636
635 KURL url(KURL(), uri); 637 KURL url(KURL(), uri);
636 638
637 if (!shouldAllowExternalLoad(url)) 639 if (!shouldAllowExternalLoad(url))
638 return &globalDescriptor; 640 return &globalDescriptor;
639 641
640 ResourceError error; 642 KURL finalURL;
641 ResourceResponse response;
642 Vector<char> data; 643 Vector<char> data;
643 644
644
645 { 645 {
646 ResourceFetcher* fetcher = XMLDocumentParserScope::currentFetcher; 646 ResourceFetcher* fetcher = XMLDocumentParserScope::currentFetcher;
647 XMLDocumentParserScope scope(0); 647 XMLDocumentParserScope scope(0);
648 // FIXME: We should restore the original global error handler as well. 648 // FIXME: We should restore the original global error handler as well.
649 649
650 if (fetcher->frame()) 650 if (fetcher->frame()) {
651 fetcher->fetchSynchronously(url, AllowStoredCredentials, error, resp onse, data); 651 FetchRequest request(ResourceRequest(url), FetchInitiatorTypeNames:: xml, ResourceFetcher::defaultResourceOptions());
652 ResourcePtr<Resource> resource = fetcher->fetchSynchronously(request );
653 if (resource && !resource->errorOccurred()) {
654 resource->resourceBuffer()->moveTo(data);
655 finalURL = resource->response().url();
656 }
657 }
652 } 658 }
653 659
654 // We have to check the URL again after the load to catch redirects. 660 // We have to check the URL again after the load to catch redirects.
655 // See <https://bugs.webkit.org/show_bug.cgi?id=21963>. 661 // See <https://bugs.webkit.org/show_bug.cgi?id=21963>.
656 if (!shouldAllowExternalLoad(response.url())) 662 if (!shouldAllowExternalLoad(finalURL))
657 return &globalDescriptor; 663 return &globalDescriptor;
658 664
659 return new OffsetBuffer(data); 665 return new OffsetBuffer(data);
660 } 666 }
661 667
662 static int readFunc(void* context, char* buffer, int len) 668 static int readFunc(void* context, char* buffer, int len)
663 { 669 {
664 // Do 0-byte reads in case of a null descriptor 670 // Do 0-byte reads in case of a null descriptor
665 if (context == &globalDescriptor) 671 if (context == &globalDescriptor)
666 return 0; 672 return 0;
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
1614 sax.initialized = XML_SAX2_MAGIC; 1620 sax.initialized = XML_SAX2_MAGIC;
1615 RefPtr<XMLParserContext> parser = XMLParserContext::createStringParser(&sax, &state); 1621 RefPtr<XMLParserContext> parser = XMLParserContext::createStringParser(&sax, &state);
1616 String parseString = "<?xml version=\"1.0\"?><attrs " + string + " />"; 1622 String parseString = "<?xml version=\"1.0\"?><attrs " + string + " />";
1617 parseChunk(parser->context(), parseString); 1623 parseChunk(parser->context(), parseString);
1618 finishParsing(parser->context()); 1624 finishParsing(parser->context());
1619 attrsOK = state.gotAttributes; 1625 attrsOK = state.gotAttributes;
1620 return state.attributes; 1626 return state.attributes;
1621 } 1627 }
1622 1628
1623 } // namespace WebCore 1629 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/xml/XSLTProcessorLibxslt.cpp ('k') | Source/web/ApplicationCacheHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698