Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 23702039: Use regular map-checks to guard string-length loading. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest
Modified:
7 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Use regular map-checks to guard string-length loading. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16709

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -117 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +11 lines, -15 lines 0 comments Download
M src/ast.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/code-stubs.h View 1 chunk +2 lines, -9 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +19 lines, -16 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +12 lines, -16 lines 0 comments Download
M src/ic.cc View 5 chunks +21 lines, -14 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +10 lines, -14 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +12 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 3 months ago (2013-09-12 15:24:24 UTC) #1
ulan
LGTM
7 years, 3 months ago (2013-09-13 09:37:09 UTC) #2
Toon Verwaest
7 years, 3 months ago (2013-09-13 09:58:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698