chrome/android/java/res/layout/item_chooser_dialog_row.xml - Issue 2370203002: Demonstrate some ideas for level list drawable [DO NOT SUBMIT]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/item_chooser_dialog_row.xml

Issue 2370203002: Demonstrate some ideas for level list drawable [DO NOT SUBMIT]

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <TextView xmlns:android="http://schemas.android.com/apk/res/android"	6 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

7 android:layout_width="match_parent"	7 android:layout_width="match_parent"

8 android:layout_height="48dp"	8 android:layout_height="48dp"

9 android:paddingStart="16dp"	9 android:paddingStart="16dp"

10 android:paddingEnd="16dp"	10 android:paddingEnd="16dp"

11 android:ellipsize="end"	11 android:ellipsize="end"

	12 android:drawablePadding="3dp"
	ortuno 2016/09/27 07:02:30 Regarding compound drawables. I'm not really oppos Regarding compound drawables. I'm not really opposed to the idea but in the end the row will consist of two lines and an icon. You can see the mock here[1] under "Paired but not connected". [1] https://drive.google.com/file/d/0B-TxIvn0COW1eWd2VWtRSmM0YjA/view Would compound drawable still make sense?
12 android:gravity="center_vertical"	13 android:gravity="center_vertical"

13 android:singleLine="true" />	14 android:singleLine="true" />

OLD	NEW