Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 23701014: Revert "Replace style sharing cousin list search with LRU" (Closed)

Created:
7 years, 3 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 3 months ago
Reviewers:
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Revert "Replace style sharing cousin list search with LRU" This reverts commit ed002c01e93c3d9ee90fdf16d7461b149176c650. Landing this as a speculative fix for the three perf regressions from the listed bug. TBR=ojan BUG=286376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157383

Patch Set 1 #

Patch Set 2 : Fix conflict #

Patch Set 3 : Fix compiler error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -89 lines) Patch
M Source/core/css/resolver/SharedStyleFinder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 5 chunks +78 lines, -42 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 4 chunks +0 lines, -11 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/23701014/1
7 years, 3 months ago (2013-09-06 17:33:51 UTC) #1
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/ContainerNode.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-06 17:33:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/23701014/5001
7 years, 3 months ago (2013-09-06 17:38:09 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-06 18:01:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/23701014/19001
7 years, 3 months ago (2013-09-06 18:16:56 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 19:31:25 UTC) #6
Message was sent while issue was closed.
Change committed as 157383

Powered by Google App Engine
This is Rietveld 408576698